Implement SVG masking with slimming paint

Implement SVG masking with slimming paint

This patch moves SVG masking over to slimming paint. The Compositing
recorder has been heavily refactored to add a parameter for color
filters and a bounding rect, as well as merging the blend mode and
compositing ops.

With this patch we pass all tests in the newly-added virt/svg/masking
directory, as well as 3 additional tests.

This patch depends on: https://codereview.chromium.org/942403002

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190793

[pdr., 2015-02-23 17:01:04]

pdr@chromium.org changed reviewers:
+ ajuma@chromium.org, chrishtr@chromium.org

[ajuma, 2015-02-23 18:19:28]

lgtm

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
File Source/core/paint/CompositingRecorder.h (right):

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
Source/core/paint/CompositingRecorder.h:20: explicit
CompositingRecorder(GraphicsContext*, DisplayItemClient, const SkXfermode::Mode,
const float, const FloatRect* = 0, ColorFilter = ColorFilterNone);
Though it's not part of this change, giving the float argument a name would make
this more readable.

https://codereview.chromium.org/947893002/diff/40001/Source/platform/graphics...
File Source/platform/graphics/paint/DrawingDisplayItem.h (left):

https://codereview.chromium.org/947893002/diff/40001/Source/platform/graphics...
Source/platform/graphics/paint/DrawingDisplayItem.h:29: protected:
Spurious change?

[jbroman, 2015-02-23 18:20:44]

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
File Source/core/paint/CompositingRecorder.h (right):

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
Source/core/paint/CompositingRecorder.h:20: explicit
CompositingRecorder(GraphicsContext*, DisplayItemClient, const SkXfermode::Mode,
const float, const FloatRect* = 0, ColorFilter = ColorFilterNone);
On 2015/02/23 18:19:28, ajuma wrote:
> Though it's not part of this change, giving the float argument a name would
make
> this more readable.

Drive-by: IMHO, the FloatRect* should also have a name.

[pdr., 2015-02-23 22:00:54]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-02-23 22:00:55]

Thanks!

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
File Source/core/paint/CompositingRecorder.h (right):

https://codereview.chromium.org/947893002/diff/40001/Source/core/paint/Compos...
Source/core/paint/CompositingRecorder.h:20: explicit
CompositingRecorder(GraphicsContext*, DisplayItemClient, const SkXfermode::Mode,
const float, const FloatRect* = 0, ColorFilter = ColorFilterNone);
On 2015/02/23 at 18:19:28, ajuma wrote:
> Though it's not part of this change, giving the float argument a name would
make this more readable.

Done

On 2015/02/23 at 18:20:44, jbroman wrote:
> On 2015/02/23 18:19:28, ajuma wrote:
> > Though it's not part of this change, giving the float argument a name would
make
> > this more readable.
> 
> Drive-by: IMHO, the FloatRect* should also have a name.

Done

https://codereview.chromium.org/947893002/diff/40001/Source/platform/graphics...
File Source/platform/graphics/paint/DrawingDisplayItem.h (left):

https://codereview.chromium.org/947893002/diff/40001/Source/platform/graphics...
Source/platform/graphics/paint/DrawingDisplayItem.h:29: protected:
On 2015/02/23 at 18:19:28, ajuma wrote:
> Spurious change?

We need to make this public so it can be created explicitly in
LayoutSVGResourceMasker::drawMaskForRenderer.

[pdr., 2015-02-23 22:00:55]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/947893002/#ps60001 (title:
"Update per reviewer comments")

[commit-bot: I haz the power, 2015-02-23 22:01:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947893002/60001

[commit-bot: I haz the power, 2015-02-23 23:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:05:01]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[pdr., 2015-02-23 23:06:56]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:07:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947893002/60001

[commit-bot: I haz the power, 2015-02-23 23:46:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 23:46:45]

Try jobs failed on following builders:
  android_blink_compile_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)

[pdr., 2015-02-24 19:16:14]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-02-24 19:17:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947893002/60001

[commit-bot: I haz the power, 2015-02-24 19:54:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 19:54:49]

Try jobs failed on following builders:
  android_blink_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

[pdr., 2015-02-24 22:15:45]

On 2015/02/24 at 19:54:49, commit-bot wrote:
> Try jobs failed on following builders:
>   android_blink_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)

Sigh... sad times. I wasted a bunch of CQ resources here.

What happened was my original cc-side patch failed to land:
https://codereview.chromium.org/942403002. I thought we were just waiting for
DEPS to roll. That's now in the CQ and we should be able to land this
momentarily.

[pdr., 2015-02-24 22:41:59]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-02-24 22:43:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947893002/60001

[commit-bot: I haz the power, 2015-02-25 00:00:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-25 00:00:25]

Try jobs failed on following builders:
  linux_blink_dbg on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/4...)

[pdr., 2015-02-25 00:45:45]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-02-25 00:45:45]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/947893002/#ps80001 (title:
"Add a mask debug print string")

[commit-bot: I haz the power, 2015-02-25 00:46:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947893002/80001

[commit-bot: I haz the power, 2015-02-25 02:17:55]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190793