Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 942403002: Add a compositing display item which replaces transparency display item (Closed)

Created:
5 years, 10 months ago by pdr.
Modified:
5 years, 10 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a compositing display item which replaces transparency display item This patch adds a compositing display item which is similar to the transparency display item (to be removed in a followup) but sports SkXfermode (combining blendmode and compositing op) as well as color filters. With this new object we can implement SVG masking. See associated blink patch: https://codereview.chromium.org/947893002 Committed: https://crrev.com/ce0b702f48b229e94ee6593e58dccd6f1d690687 Cr-Commit-Position: refs/heads/master@{#317905}

Patch Set 1 #

Patch Set 2 : Forward decls and imports oh my #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -20 lines) Patch
M cc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/blink/web_display_item_list_impl.h View 1 2 chunks +6 lines, -0 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 4 chunks +20 lines, -4 lines 0 comments Download
M cc/cc.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A + cc/resources/compositing_display_item.h View 4 chunks +22 lines, -16 lines 0 comments Download
A cc/resources/compositing_display_item.cc View 1 chunk +81 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
pdr.
5 years, 10 months ago (2015-02-23 16:58:51 UTC) #2
pdr.
5 years, 10 months ago (2015-02-23 16:58:54 UTC) #3
ajuma
lgtm
5 years, 10 months ago (2015-02-23 18:05:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942403002/20001
5 years, 10 months ago (2015-02-23 18:11:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61766)
5 years, 10 months ago (2015-02-23 18:14:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/942403002/20001
5 years, 10 months ago (2015-02-24 22:16:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 22:39:03 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 22:40:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ce0b702f48b229e94ee6593e58dccd6f1d690687
Cr-Commit-Position: refs/heads/master@{#317905}

Powered by Google App Engine
This is Rietveld 408576698