Add icui18n dependency to bookmarks

Add icui18n dependency to bookmarks

bookmark_model.cc uses icu::Collator directly so it should have
direct dependency to icui18n, otherwise there will be a linking
issue on Linux for component builds and configuration_policy==0,
policy_component won't link because of the missing icui8n dependency.
It's a followup of CL 938003002.

Committed: https://crrev.com/7c3b3fbede3e3c3e71aa90cfd12d6e6b67eec054
Cr-Commit-Position: refs/heads/master@{#317426}

[Jiang Jiang, 2015-02-20 17:25:31]

jiangj@opera.com changed reviewers:
+ sky@chromium.org

[Jiang Jiang, 2015-02-20 17:25:32]

Please take a look again, thanks.

[sky, 2015-02-20 18:09:41]

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi#ne...
components/bookmarks.gypi:18: '../third_party/icu/icu.gyp:icui18n',
Do any gn files need to be updated too?

[tfarina, 2015-02-20 19:12:08]

tfarina@chromium.org changed reviewers:
+ tfarina@chromium.org

[tfarina, 2015-02-20 19:12:09]

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi#ne...
components/bookmarks.gypi:18: '../third_party/icu/icu.gyp:icui18n',
On 2015/02/20 18:09:41, sky wrote:
> Do any gn files need to be updated too?

I think no, because they already depends on icu:
https://chromium.googlesource.com/chromium/src/+/master/components/bookmarks/...

[Jiang Jiang, 2015-02-20 20:17:19]

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi
File components/bookmarks.gypi (right):

https://codereview.chromium.org/947443004/diff/1/components/bookmarks.gypi#ne...
components/bookmarks.gypi:18: '../third_party/icu/icu.gyp:icui18n',
On 2015/02/20 19:12:09, tfarina wrote:
> On 2015/02/20 18:09:41, sky wrote:
> > Do any gn files need to be updated too?
> 
> I think no, because they already depends on icu:
>
https://chromium.googlesource.com/chromium/src/+/master/components/bookmarks/...

Yes, it appears that the icu group in gn contains both icui18n and icuuc.

[sky, 2015-02-20 21:36:48]

LGTM

[tfarina, 2015-02-20 21:44:13]

lgtm

[tfarina, 2015-02-20 21:44:22]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2015-02-20 21:45:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/947443004/1

[commit-bot: I haz the power, 2015-02-20 22:32:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-20 22:33:28]

Patchset 1 (id:??) landed as
https://crrev.com/7c3b3fbede3e3c3e71aa90cfd12d6e6b67eec054
Cr-Commit-Position: refs/heads/master@{#317426}