Add icui18n dependency to bookmarks

components/bookmarks.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //components/bookmarks/browser
       'target_name': 'bookmarks_browser',
       'type': 'static_library',
       'include_dirs': [
         '..',
       ],
       'dependencies': [
         '../base/base.gyp:base',
         '../base/base.gyp:base_i18n',
         '../net/net.gyp:net',
+        '../third_party/icu/icu.gyp:icui18n',

[sky, 2015/02/20 18:09:41]

Do any gn files need to be updated too?

[tfarina, 2015/02/20 19:12:09]

I think no, because they already depends on icu:
https://chromium.googlesource.com/chromium/src/+/master/components/bookmarks/...

[Jiang Jiang, 2015/02/20 20:17:19]

Yes, it appears that the icu group in gn contains both icui18n and icuuc.

         '../third_party/icu/icu.gyp:icuuc',
         '../ui/base/ui_base.gyp:ui_base',
         '../ui/gfx/gfx.gyp:gfx',
         '../url/url.gyp:url_lib',
         'bookmarks_common',
         'components_strings.gyp:components_strings',
         'favicon_base',
         'keyed_service_core',
         'pref_registry',
         'query_parser',
@@ skipping 131 matching lines @@
           'type': 'none',
           'variables': {
             'source_file': 'bookmarks/common/android/bookmark_type.h',
           },
           'includes': [ '../build/android/java_cpp_enum.gypi' ],
         },
       ],
     }]
   ],
 }