components/bookmarks.gypi - Issue 947443004: Add icui18n dependency to bookmarks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks.gypi

Issue 947443004: Add icui18n dependency to bookmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks.gypi

diff --git a/components/bookmarks.gypi b/components/bookmarks.gypi

index a7a1d9b43752512d48a3b13afc3f3ec4adbb8647..c697e02ffafd24407ae056ca421bd3776bfc4e95 100644

--- a/components/bookmarks.gypi

+++ b/components/bookmarks.gypi

@@ -15,6 +15,7 @@

'../base/base.gyp:base',

'../base/base.gyp:base_i18n',

'../net/net.gyp:net',

+ '../third_party/icu/icu.gyp:icui18n',

sky 2015/02/20 18:09:41 Do any gn files need to be updated too?

tfarina 2015/02/20 19:12:09 I think no, because they already depends on icu: h

Jiang Jiang 2015/02/20 20:17:19 Yes, it appears that the icu group in gn contains

'../third_party/icu/icu.gyp:icuuc',

'../ui/base/ui_base.gyp:ui_base',

'../ui/gfx/gfx.gyp:gfx',

« no previous file with comments | « no previous file | no next file » | no next file with comments »