Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 947393002: InlinedVisitor: Migrate dom to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, shans, rjwright, blink-reviews-style_chromium.org, dstockwell, webcomponents-bugzilla_chromium.org, blink-reviews-animation_chromium.org, sof, eae+blinkwatch, Timothy Loh, Mike Lawther (Google), blink-reviews-dom_chromium.org, dglazkov+blink, Steve Block, darktears, Eric Willigers, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate dom to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190729

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -191 lines) Patch
M Source/core/dom/ActiveDOMObjectTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Attr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CSSSelectorWatch.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/CSSSelectorWatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildListMutationScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildListMutationScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ChildNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRect.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRectList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ClientRectList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContextFeatures.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMError.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMException.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMMatrixReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMPointReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMRectReadOnly.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMStringList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMStringMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMTokenList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DOMURL.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DatasetDOMStringMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DatasetDOMStringMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Document.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Document.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/DocumentMarker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentMarker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentMarkerController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DocumentParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentParserClient.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/DocumentTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementData.h View 3 chunks +4 lines, -4 lines 1 comment Download
M Source/core/dom/ElementData.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ElementDataCache.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementDataCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementRareData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ElementRareData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EmptyNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/EmptyNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Fullscreen.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/IdTargetObserverRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/LiveNodeListBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageChannel.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverRegistration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationObserverRegistration.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MutationRecord.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/NamedNodeMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeFilterCondition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIterator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/NodeIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIteratorBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeIteratorBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeListsNodeData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeListsNodeData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.h View 2 chunks +3 lines, -3 lines 1 comment Download
M Source/core/dom/NodeRareData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/PendingScript.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PendingScript.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PresentationAttributeStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ProcessingInstruction.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Range.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/RequestAnimationFrameCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScopedWindowFocusAllowedIndicator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptedAnimationController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ScriptedAnimationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ShadowTreeStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StringCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleEngine.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/StyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/StyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TemplateContentDocumentFragment.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Text.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/core/dom/Touch.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Touch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TouchList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScope.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeScopeStyleSheetCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/TreeWalker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UserActionElementSet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/UserActionElementSet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/VisitedLinkState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/VisitedLinkState.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackInvocation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementCallbackQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementDefinition.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementDefinition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskDispatcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskQueueBase.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskQueueBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskRunQueue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementObserver.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStep.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistrationContext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ContentDistribution.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ContentDistribution.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ElementShadow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRoot.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ShadowRootRareData.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-24 02:12:01 UTC) #1
tkent
lgtm
5 years, 10 months ago (2015-02-24 07:55:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/947393002/1
5 years, 10 months ago (2015-02-24 07:56:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190729
5 years, 10 months ago (2015-02-24 09:10:43 UTC) #6
haraken
5 years, 10 months ago (2015-02-24 09:18:36 UTC) #8
Message was sent while issue was closed.
LGTM

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/ElementData.h
File Source/core/dom/ElementData.h (right):

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/ElementData....
Source/core/dom/ElementData.h:82: DECLARE_TRACE_AFTER_DISPATCH();

Add a comment on why we need traceAfterDispatch.

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/NodeRareData.h
File Source/core/dom/NodeRareData.h (right):

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/NodeRareData...
Source/core/dom/NodeRareData.h:111: DECLARE_TRACE_AFTER_DISPATCH();

Add a comment on why we need traceAfterDispatch.

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/Text.cpp
File Source/core/dom/Text.cpp (right):

https://codereview.chromium.org/947393002/diff/1/Source/core/dom/Text.cpp#new...
Source/core/dom/Text.cpp:449:
increaseExternallyAllocatedBytesAliveIfNeeded(m_data.length());

Sigbjorn: Do we want to call increaseExternallyAllocatedBytesAlive in a visitor
other than InlineGlobalMarkingVisitor?

Powered by Google App Engine
This is Rietveld 408576698