Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: Source/core/dom/NodeRareData.cpp

Issue 947393002: InlinedVisitor: Migrate dom to use inlined tracing (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 namespace blink { 39 namespace blink {
40 40
41 struct SameSizeAsNodeRareData { 41 struct SameSizeAsNodeRareData {
42 void* m_pointer[2]; 42 void* m_pointer[2];
43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData; 43 OwnPtrWillBeMember<NodeMutationObserverData> m_mutationObserverData;
44 unsigned m_bitfields; 44 unsigned m_bitfields;
45 }; 45 };
46 46
47 static_assert(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), "NodeRareD ata should stay small"); 47 static_assert(sizeof(NodeRareData) == sizeof(SameSizeAsNodeRareData), "NodeRareD ata should stay small");
48 48
49 void NodeRareData::traceAfterDispatch(Visitor* visitor) 49 DEFINE_TRACE_AFTER_DISPATCH(NodeRareData)
50 { 50 {
51 visitor->trace(m_mutationObserverData); 51 visitor->trace(m_mutationObserverData);
52 // Do not keep empty NodeListsNodeData objects around. 52 // Do not keep empty NodeListsNodeData objects around.
53 if (m_nodeLists && m_nodeLists->isEmpty()) 53 if (m_nodeLists && m_nodeLists->isEmpty())
54 m_nodeLists.clear(); 54 m_nodeLists.clear();
55 else 55 else
56 visitor->trace(m_nodeLists); 56 visitor->trace(m_nodeLists);
57 } 57 }
58 58
59 void NodeRareData::trace(Visitor* visitor) 59 DEFINE_TRACE(NodeRareData)
60 { 60 {
61 if (m_isElementRareData) 61 if (m_isElementRareData)
62 static_cast<ElementRareData*>(this)->traceAfterDispatch(visitor); 62 static_cast<ElementRareData*>(this)->traceAfterDispatch(visitor);
63 else 63 else
64 traceAfterDispatch(visitor); 64 traceAfterDispatch(visitor);
65 } 65 }
66 66
67 void NodeRareData::finalizeGarbageCollectedObject() 67 void NodeRareData::finalizeGarbageCollectedObject()
68 { 68 {
69 RELEASE_ASSERT(!renderer()); 69 RELEASE_ASSERT(!renderer());
70 if (m_isElementRareData) 70 if (m_isElementRareData)
71 static_cast<ElementRareData*>(this)->~ElementRareData(); 71 static_cast<ElementRareData*>(this)->~ElementRareData();
72 else 72 else
73 this->~NodeRareData(); 73 this->~NodeRareData();
74 } 74 }
75 75
76 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow 76 // Ensure the 10 bits reserved for the m_connectedFrameCount cannot overflow
77 static_assert(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameC ountBits), "Frame limit should fit in rare data count"); 77 static_assert(FrameHost::maxNumberOfFrames < (1 << NodeRareData::ConnectedFrameC ountBits), "Frame limit should fit in rare data count");
78 78
79 } // namespace blink 79 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698