Issue 947223003: Merge: Block nested system print dialogs on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 947223003: Merge: Block nested system print dialogs on Windows. (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)

Modified:
5 years, 10 months ago

Reviewers:
Aleksey Shlyapnikov

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2272

Target Ref:
refs/pending/branch-heads/2272

Project:
chromium

Visibility:
Public.

Merge: Block nested system print dialogs on Windows. Browser needs to allow nested tasks to update backgroud tabs. If rendered requests new system dialog, asan build crashes in COMDLG32.dll NOTRY=true BUG=451753 Review URL: https://codereview.chromium.org/934393003 Cr-Commit-Position: refs/heads/master@{#317611} (cherry picked from commit a58ec6a8c37ed1146206c2e4143b58249bdf5255) Conflicts: printing/printing_context_win.cc R=alekseys@chromium.org Review URL: https://codereview.chromium.org/947223003 Cr-Commit-Position: refs/branch-heads/2272@{#365} Cr-Branched-From: 827a380cfdb31aa54c8d56e63ce2c3fd8c3ba4d4-refs/heads/master@{#310958} Committed: https://chromium.googlesource.com/chromium/src/+/4c02af6cec7529da8acf1cffdbd468afe0cbc36e Committed: https://chromium.googlesource.com/chromium/src/+/21f0a4cc2d785589c99478a6d29da080ff8c7ceb

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	printing/printing_context_system_dialog_win.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
	M	printing/printing_context_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Vitaly Buka (NO REVIEWS)

Committed patchset #1 (id:1) manually as 4c02af6cec7529da8acf1cffdbd468afe0cbc36e (presubmit successful).

5 years, 10 months ago (2015-02-23 23:42:58 UTC) #4

Vitaly Buka (NO REVIEWS)

5 years, 10 months ago (2015-02-23 23:50:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
21f0a4cc2d785589c99478a6d29da080ff8c7ceb (presubmit successful).