Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 934393003: Block nested system print dialogs on Windows (Closed)

Created:
5 years, 10 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@no_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Block nested system print dialogs on Windows. Browser needs to allow nested tasks to update backgroud tabs. If rendered requests new system dialog, asan build crashes in COMDLG32.dll NOTRY=true BUG=451753 Committed: https://crrev.com/a58ec6a8c37ed1146206c2e4143b58249bdf5255 Cr-Commit-Position: refs/heads/master@{#317611}

Patch Set 1 #

Patch Set 2 : Mon Feb 23 09:47:28 PST 2015 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M printing/printing_context_system_dialog_win.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M printing/printing_context_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
Vitaly Buka (NO REVIEWS)
5 years, 10 months ago (2015-02-23 03:31:03 UTC) #2
Aleksey Shlyapnikov
lgtm
5 years, 10 months ago (2015-02-23 17:39:05 UTC) #3
Aleksey Shlyapnikov
lgtm lgtm
5 years, 10 months ago (2015-02-23 17:39:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934393003/20001
5 years, 10 months ago (2015-02-23 17:51:46 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61749)
5 years, 10 months ago (2015-02-23 17:55:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934393003/20001
5 years, 10 months ago (2015-02-23 18:29:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/934393003/20001
5 years, 10 months ago (2015-02-23 18:30:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 18:30:59 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 18:31:33 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a58ec6a8c37ed1146206c2e4143b58249bdf5255
Cr-Commit-Position: refs/heads/master@{#317611}

Powered by Google App Engine
This is Rietveld 408576698