Source/bindings/scripts/v8_attributes.py - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 8899902608cd2b6b21f6e1d73f80c3ef515bfc12..f347c69569218e00bf52f8e3e87a9c8eff50d804 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -126,7 +126,7 @@ def attribute_context(interface, attribute):

'only_exposed_to_private_script': is_only_exposed_to_private_script,

'per_context_enabled_function': v8_utilities.per_context_enabled_function_name(attribute), # [PerContextEnabled]

'private_script_v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(

- extended_attributes, 'v8Value', 'cppValue', isolate='scriptState->isolate()', used_in_private_script=True),

+ extended_attributes, 'v8Value', 'cppValue', bailout_return_value='false', isolate='scriptState->isolate()'),

'property_attributes': property_attributes(interface, attribute),

'put_forwards': 'PutForwards' in extended_attributes,

'reflect_empty': extended_attributes.get('ReflectEmpty'),

« no previous file with comments | « Source/bindings/core/v8/V8StringResource.h ('k') | Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »