Source/bindings/scripts/v8_dictionary.py - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_dictionary.py

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_dictionary.py

diff --git a/Source/bindings/scripts/v8_dictionary.py b/Source/bindings/scripts/v8_dictionary.py

index 3e8ee8cc192ee03ce4136ac0ec47504251279075..2a80c45ca754fb8e90789c205c153261a407e7b0 100644

--- a/Source/bindings/scripts/v8_dictionary.py

+++ b/Source/bindings/scripts/v8_dictionary.py

@@ -117,11 +117,11 @@ def member_context(dictionary, member):

'name': member.name,

'setter_name': setter_name_for_dictionary_member(member),

'null_setter_name': null_setter_name_for_dictionary_member(member),

- 'use_output_parameter_for_result': unwrapped_idl_type.use_output_parameter_for_result,

'v8_default_value': v8_default_value,

'v8_value_to_local_cpp_value': unwrapped_idl_type.v8_value_to_local_cpp_value(

member.extended_attributes, member.name + 'Value',

- member.name, isolate='isolate', restricted_float=restricted_float),

+ member.name, isolate='isolate', use_exception_state=True,

+ restricted_float=restricted_float),

}

« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_interface.py » ('j') | no next file with comments »