Source/bindings/core/v8/V8StringResource.h - Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8StringResource.h

Issue 946973005: IDL: Drop value conversion (V8 -> C++) macros from generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8StringResource.h

diff --git a/Source/bindings/core/v8/V8StringResource.h b/Source/bindings/core/v8/V8StringResource.h

index 6539094c5f3a28547615415a4093afe4d5f531de..0c85264241a56c75fffc8caf6c3be67989b7ef9c 100644

--- a/Source/bindings/core/v8/V8StringResource.h

+++ b/Source/bindings/core/v8/V8StringResource.h

@@ -179,6 +179,12 @@ public:

{

}

+ V8StringResource(const String& string)

+ : m_mode(Externalize)

+ , m_string(string)

+ {

+ }

void operator=(v8::Handle<v8::Value> object)

{

m_v8Object = object;

« no previous file with comments | « Source/bindings/core/v8/V8BindingMacros.h ('k') | Source/bindings/scripts/v8_attributes.py » ('j') | no next file with comments »