Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 946553003: [CSS Grid Layout] Avoid reset override logical width/height for non relative elements (Closed)

Created:
5 years, 10 months ago by Manuel Rego
Modified:
5 years, 9 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, Manuel Rego, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Avoid reset override logical width/height for non relative elements We were setting the override logical width/height to -1 (no possible resolution) for all the items regardless if they've a relative width/height or a fixed one. Added the condition, including not only items with percentage logical width/height but also relative, to avoid overriding the value for items with fixed width/height as it's not needed. TEST=fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191347

Patch Set 1 #

Patch Set 2 : Rebased patch after LayoutGrid rename #

Total comments: 3

Patch Set 3 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -7 lines) Patch
M LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html View 1 2 2 chunks +84 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 2 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Manuel Rego
5 years, 10 months ago (2015-02-20 15:35:24 UTC) #2
Julien - ping for review
lgtm https://codereview.chromium.org/946553003/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html File LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html (right): https://codereview.chromium.org/946553003/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html#newcode18 LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:18: min-height: 100%; Let's add similar testing for max-width ...
5 years, 9 months ago (2015-03-02 18:05:21 UTC) #3
Manuel Rego
Thanks for the review. https://codereview.chromium.org/946553003/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html File LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html (right): https://codereview.chromium.org/946553003/diff/20001/LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html#newcode18 LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:18: min-height: 100%; On 2015/03/02 18:05:20, ...
5 years, 9 months ago (2015-03-05 06:31:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946553003/40001
5 years, 9 months ago (2015-03-05 06:32:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 08:12:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191347

Powered by Google App Engine
This is Rietveld 408576698