Source/core/layout/LayoutBox.cpp - Issue 946553003: [CSS Grid Layout] Avoid reset override logical width/height for non relative elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBox.cpp

Issue 946553003: [CSS Grid Layout] Avoid reset override logical width/height for non relative elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/LayoutBox.cpp

diff --git a/Source/core/layout/LayoutBox.cpp b/Source/core/layout/LayoutBox.cpp

index 052e2f01f00296eda3883006fe978dde97fbb6cd..402c8d1aceffca1a703b9172f5f2356f746ffd92 100644

--- a/Source/core/layout/LayoutBox.cpp

+++ b/Source/core/layout/LayoutBox.cpp

@@ -4508,6 +4508,13 @@ LayoutPoint LayoutBox::topLeftLocation() const

return containerBlock->flipForWritingModeForChild(this, location());

}

+bool LayoutBox::hasRelativeLogicalWidth() const

+ return style()->logicalWidth().isPercent()

+ || style()->logicalMinWidth().isPercent()

+ || style()->logicalMaxWidth().isPercent();

bool LayoutBox::hasRelativeLogicalHeight() const

{

return style()->logicalHeight().isPercent()

« no previous file with comments | « Source/core/layout/LayoutBox.h ('k') | Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »