LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html - Issue 946553003: [CSS Grid Layout] Avoid reset override logical width/height for non relative elements

Side by Side Diff: LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html

Issue 946553003: [CSS Grid Layout] Avoid reset override logical width/height for non relative elements (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased patch after LayoutGrid rename Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution-expected.txt » ('j') | Source/core/layout/LayoutGrid.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <link href="resources/grid.css" rel="stylesheet">	3 <link href="resources/grid.css" rel="stylesheet">

4 <style>	4 <style>

5 .gridMinMaxMinMax {	5 .gridMinMaxMinMax {

6 grid-template-columns: 50px 100px;	6 grid-template-columns: 50px 100px;

7 grid-template-rows: minmax(10px, min-content) minmax(50px, 100px);	7 grid-template-rows: minmax(10px, min-content) minmax(50px, 100px);

8 }	8 }

9	9

10 .gridAutoAuto {	10 .gridAutoAuto {

11 grid-template-columns: 50px 100px;	11 grid-template-columns: 50px 100px;

12 grid-template-rows: auto auto;	12 grid-template-rows: auto auto;

13 }	13 }

	14

	15 .sizedToGridAreaMinSizes {

	16 font: 10px/1 Ahem;

	17 min-width: 100%;

	18 min-height: 100%;
	Julien - ping for review 2015/03/02 18:05:20 Let's add similar testing for max-width / max-heig Let's add similar testing for max-width / max-height too. Manuel Rego 2015/03/05 06:31:07 Done. Show quoted text On 2015/03/02 18:05:20, Julien Chaffraix - PST wrote: > Let's add similar testing for max-width / max-height too. Done.
	19 }

14 </style>	20 </style>

15 <script src="../../resources/check-layout.js"></script>	21 <script src="../../resources/check-layout.js"></script>

16 <body onload="checkLayout('.grid')">	22 <body onload="checkLayout('.grid')">

17	23

18 <p>Test that grid items with a percentage logical height inside a grid without e xplicit sizes resolve their size properly.</p>	24 <p>Test that grid items with a percentage logical height inside a grid without e xplicit sizes resolve their size properly.</p>

19	25

20 <div class="unconstrainedContainer" style="position: relative">	26 <div class="unconstrainedContainer" style="position: relative">

21 <div class="grid gridMinMaxMinMax">	27 <div class="grid gridMinMaxMinMax">

22 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" da ta-expected-height="20">XXXXX XXXXXX</div>	28 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" da ta-expected-height="20">XXXXX XXXXXX</div>

23 <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="100" data-expected-height="20">XXXXX XXXXXX</div>	29 <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="100" data-expected-height="20">XXXXX XXXXXX</div>

(...skipping 22 matching lines...) Expand all Loading...
46	52

47 <div class="unconstrainedContainer" style="position: relative">	53 <div class="unconstrainedContainer" style="position: relative">

48 <div class="grid gridAutoAuto">	54 <div class="grid gridAutoAuto">

49 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" da ta-expected-height="30">XXXXX XXXXXX</div>	55 <div class="sizedToGridArea firstRowFirstColumn" data-expected-width="50" da ta-expected-height="30">XXXXX XXXXXX</div>

50 <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="100" data-expected-height="30">XXXXX XXXXX XXXXXX</div>	56 <div class="sizedToGridArea firstRowSecondColumn" data-expected-width="100" data-expected-height="30">XXXXX XXXXX XXXXXX</div>

51 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="50" d ata-expected-height="40">XXXXX XXXXXX</div>	57 <div class="sizedToGridArea secondRowFirstColumn" data-expected-width="50" d ata-expected-height="40">XXXXX XXXXXX</div>

52 <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="100" data-expected-height="40">XXXXX XXXXX XXXXX XXXXXX</div>	58 <div class="sizedToGridArea secondRowSecondColumn" data-expected-width="100" data-expected-height="40">XXXXX XXXXX XXXXX XXXXXX</div>

53 </div>	59 </div>

54 </div>	60 </div>

55	61

	62 <div class="unconstrainedContainer" style="position: relative">

	63 <div class="grid gridMinMaxMinMax">

	64 <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width ="50" data-expected-height="20">XXXXX XXXXXX</div>

	65 <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-widt h="100" data-expected-height="20">XXXXX XXXXXX</div>

	66 <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-widt h="50" data-expected-height="100">XXXXX XXXXXX</div>

	67 <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-wid th="100" data-expected-height="100">XXXXX XXXXXX</div>

	68 </div>

	69 </div>

	70

	71 <div style="position: relative; height: 100px;">

	72 <div class="grid gridMinMaxMinMax">

	73 <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width ="50" data-expected-height="20">XXXXX XXXXXX</div>

	74 <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-widt h="100" data-expected-height="20">XXXXX XXXXXX</div>

	75 <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-widt h="50" data-expected-height="100">XXXXX XXXXXX</div>

	76 <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-wid th="100" data-expected-height="100">XXXXX XXXXXX</div>

	77 </div>

	78 </div>

	79

	80 <div style="position: relative;">

	81 <div class="grid gridMinMaxMinMax" style="height: 100px;">

	82 <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width ="50" data-expected-height="20">XXXXX XXXXXX</div>

	83 <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-widt h="100" data-expected-height="20">XXXXX XXXXXX</div>

	84 <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-widt h="50" data-expected-height="80">XXXXX XXXXXX</div>

	85 <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-wid th="100" data-expected-height="80">XXXXX XXXXXX</div>

	86 </div>

	87 </div>

	88

	89 <div class="unconstrainedContainer" style="position: relative">

	90 <div class="grid gridAutoAuto">

	91 <div class="sizedToGridAreaMinSizes firstRowFirstColumn" data-expected-width ="50" data-expected-height="30">XXXXX XXXXXX</div>

	92 <div class="sizedToGridAreaMinSizes firstRowSecondColumn" data-expected-widt h="100" data-expected-height="30">XXXXX XXXXX XXXXXX</div>

	93 <div class="sizedToGridAreaMinSizes secondRowFirstColumn" data-expected-widt h="50" data-expected-height="40">XXXXX XXXXXX</div>

	94 <div class="sizedToGridAreaMinSizes secondRowSecondColumn" data-expected-wid th="100" data-expected-height="40">XXXXX XXXXX XXXXX XXXXXX</div>

	95 </div>

	96 </div>

	97

56 </body>	98 </body>

57 </html>	99 </html>

OLD	NEW