Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Issue 946403002: Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything (Closed)

Created:
5 years, 10 months ago by Paweł Hajdan Jr.
Modified:
5 years, 10 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything BUG=453471 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294180

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -6 lines) Patch
M scripts/slave/recipe_modules/chromium/chromium_fyi.py View 1 chunk +4 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Builder__clobber_.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 1 chunk +11 lines, -0 lines 0 comments Download
A + scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json View 1 chunk +35 lines, -3 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clobber_rel_ng.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Paweł Hajdan Jr.
5 years, 10 months ago (2015-02-23 15:12:40 UTC) #2
jam
lgtm, thanks!
5 years, 10 months ago (2015-02-23 15:17:35 UTC) #3
sky
LGTM
5 years, 10 months ago (2015-02-23 21:05:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/946403002/1
5 years, 10 months ago (2015-02-23 21:06:28 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 21:09:24 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294180

Powered by Google App Engine
This is Rietveld 408576698