scripts/slave/recipes/chromium_trybot.py - Issue 946403002: Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.py

Issue 946403002: Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Builder__clobber_.json ('k') | scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.py

diff --git a/scripts/slave/recipes/chromium_trybot.py b/scripts/slave/recipes/chromium_trybot.py

index 20a5d94aaa94d1b1ec6e9d51d6e75a78c9cec18e..37e5bd7459247b72005a3e98b2b8eda918d397da 100644

--- a/scripts/slave/recipes/chromium_trybot.py

+++ b/scripts/slave/recipes/chromium_trybot.py

@@ -444,6 +444,17 @@ def GenTests(api):

props(mastername=mastername, buildername=buildername)

)

+ # Regression test for http://crbug.com/453471#c16

+ yield (

+ api.test('clobber_analyze') +

+ props(buildername='linux_chromium_clobber_rel_ng') +

+ api.platform.name('linux') +

+ api.override_step_data(

+ 'analyze',

+ api.json.output({'status': 'Found dependency', 'targets': [],

+ 'build_targets': ['base_unittests', 'net_unittests']}))

+ )

yield (

api.test('invalid_results') +

props() +