scripts/slave/recipe_modules/chromium/chromium_fyi.py - Issue 946403002: Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/chromium_fyi.py

Issue 946403002: Fix "analyze" on linux_chromium_clobber_rel_ng always compiling everything (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/chromium_fyi.py

diff --git a/scripts/slave/recipe_modules/chromium/chromium_fyi.py b/scripts/slave/recipe_modules/chromium/chromium_fyi.py

index ad4639b03054a1fe8a7e84d50afd0249618dbeb3..f7663a893a41f1fc9485f544dbcd12fe149f66d2 100644

--- a/scripts/slave/recipe_modules/chromium/chromium_fyi.py

+++ b/scripts/slave/recipe_modules/chromium/chromium_fyi.py

@@ -773,7 +773,10 @@ SPEC = {

'TARGET_BITS': 64,

'compile_targets': [

- 'chromium_swarm_tests',

+ # chromium_tests.analyze treats "all" compile target in a special way;

+ # Make sure to trigger it to make sure we respect compile targets

+ # returned by gyp analyzer.

+ 'all',

'testing': {

'platform': 'linux',

« no previous file with comments | « no previous file | scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_Builder__clobber_.json » ('j') | no next file with comments »