Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 945803007: Catch AccessDeniedException on bots without permission to download SDK extras. (Closed)

Created:
5 years, 10 months ago by navabi
Modified:
5 years, 10 months ago
Reviewers:
cjhopman, sbc, hinoka
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Catch AccessDeniedException on bots without permission to download SDK extras. BUG=460463 Committed: https://crrev.com/70b983128e5d59a37902bf5259eccb25c0378a4a Cr-Commit-Position: refs/heads/master@{#317383}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/download_sdk_extras.py View 2 chunks +7 lines, -5 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
navabi
https://codereview.chromium.org/945803007/diff/1/build/download_sdk_extras.py File build/download_sdk_extras.py (right): https://codereview.chromium.org/945803007/diff/1/build/download_sdk_extras.py#newcode51 build/download_sdk_extras.py:51: return 0 This will be removed as a hook ...
5 years, 10 months ago (2015-02-20 19:50:34 UTC) #2
cjhopman
lgtm
5 years, 10 months ago (2015-02-20 19:53:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945803007/1
5 years, 10 months ago (2015-02-20 19:55:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-20 20:15:32 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-20 20:17:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70b983128e5d59a37902bf5259eccb25c0378a4a
Cr-Commit-Position: refs/heads/master@{#317383}

Powered by Google App Engine
This is Rietveld 408576698