Catch AccessDeniedException on bots without permission to download SDK extras.

build/download_sdk_extras.py

Index: build/download_sdk_extras.py
diff --git a/build/download_sdk_extras.py b/build/download_sdk_extras.py
index 56ee18f4880137b361ca8e63e5fb44a525fcd542..d22d8850c2e762919fb70d1fd7002f2cdebc8c35 100755
--- a/build/download_sdk_extras.py
+++ b/build/download_sdk_extras.py
@@ -49,9 +49,6 @@ def main():
   if not os.environ.get('CHROME_HEADLESS'):
     # This is not a buildbot checkout.
     return 0

[navabi, 2015/02/20 19:50:33]

This will be removed as a hook anyway. Right now there are too many problems
being caused because we have a wide variety of bots that are set up in very
different ways (e.g. some android bots set OS=android in the env GYP_DEFINES,
some do not; see the bug).

This will be moved as an explicit and separate step on all bots that compile on
Android. In the meantime, I suggest we allow every slave (i.e.
CHROME_HEADLESS=1) that has permissions to download the SDK extras. Only the
Android bots should have those permissions.

WDYT?

-  elif 'OS=android' not in os.environ.get('GYP_DEFINES', ''):
-    # Not an Android buildbot.
-    return 0
   # Update the android_sdk_extras.json file to update downloaded packages.
   with open(SDK_EXTRAS_JSON_FILE) as json_file:
     packages = json.load(json_file)
@@ -59,8 +56,13 @@ def main():
     local_zip = '%s/%s' % (SDK_EXTRAS_PATH, package['zip'])
     if not os.path.exists(local_zip):
       package_zip = '%s/%s' % (SDK_EXTRAS_BUCKET, package['zip'])
-      subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',
-                             'cp', package_zip, local_zip])
+      try:
+        subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',
+                               'cp', package_zip, local_zip])
+      except AccessDeniedException:
+        print ('WARNING: Bot does not have permission to download SDK packages.'
+               ' If this bot compiles for Android, it may have errors.')
+        return 0
     # Always clean dir and extract zip to ensure correct contents.
     clean_and_extract(package['dir_name'], package['package'], package['zip'])