Catch AccessDeniedException on bots without permission to download SDK extras.

build/download_sdk_extras.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Script to download sdk/extras packages on the bots from google storage.
 
 The script expects arguments that specify zips file in the google storage
 bucket named: <dir in SDK extras>_<package name>_<version>.zip. The file will
 be extracted in the android_tools/sdk/extras directory on the test bots. This
@@ skipping 30 matching lines @@
   if os.path.exists(local_dir):
     shutil.rmtree(local_dir)
   local_zip = '%s/%s' % (SDK_EXTRAS_PATH, zip_file)
   with zipfile.ZipFile(local_zip) as z:
     z.extractall(path=SDK_EXTRAS_PATH)
 
 
 def main():
   if not os.environ.get('CHROME_HEADLESS'):
     # This is not a buildbot checkout.
     return 0

[navabi, 2015/02/20 19:50:33]

This will be removed as a hook anyway. Right now there are too many problems
being caused because we have a wide variety of bots that are set up in very
different ways (e.g. some android bots set OS=android in the env GYP_DEFINES,
some do not; see the bug).

This will be moved as an explicit and separate step on all bots that compile on
Android. In the meantime, I suggest we allow every slave (i.e.
CHROME_HEADLESS=1) that has permissions to download the SDK extras. Only the
Android bots should have those permissions.

WDYT?

-  elif 'OS=android' not in os.environ.get('GYP_DEFINES', ''):
-    # Not an Android buildbot.
-    return 0
   # Update the android_sdk_extras.json file to update downloaded packages.
   with open(SDK_EXTRAS_JSON_FILE) as json_file:
     packages = json.load(json_file)
   for package in packages:
     local_zip = '%s/%s' % (SDK_EXTRAS_PATH, package['zip'])
     if not os.path.exists(local_zip):
       package_zip = '%s/%s' % (SDK_EXTRAS_BUCKET, package['zip'])
-      subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',
-                             'cp', package_zip, local_zip])
+      try:
+        subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',
+                               'cp', package_zip, local_zip])
+      except AccessDeniedException:
+        print ('WARNING: Bot does not have permission to download SDK packages.'
+               ' If this bot compiles for Android, it may have errors.')
+        return 0
     # Always clean dir and extract zip to ensure correct contents.
     clean_and_extract(package['dir_name'], package['package'], package['zip'])
 
 
 if __name__ == '__main__':
   sys.exit(main())