Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 945713002: win vs2015: fix variable shadowing warnings (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win vs2015: fix variable shadowing warnings in net/base d:\src\cr2\src\net\base\mime_util.cc(1286): warning C4456: declaration of 'extension' hides previous local declaration d:\src\cr2\src\net\base\mime_util.cc(1278): note: see declaration of 'extension' d:\src\cr2\src\net\base\upload_file_element_reader.cc(122): warning C4457: declaration of 'result' hides function parameter d:\src\cr2\src\net\base\upload_file_element_reader.cc(106): note: see declaration of 'result' d:\src\cr2\src\net\base\url_util.cc(47): warning C4457: declaration of 'value' hides function parameter d:\src\cr2\src\net\base\url_util.cc(33): note: see declaration of 'value' R=rdsmith@chromium.org BUG=440500 Committed: https://crrev.com/edba32ccb3147b5bc034f44a26d5e886c72f0366 Cr-Commit-Position: refs/heads/master@{#317603}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M net/base/mime_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/base/upload_file_element_reader.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M net/base/url_util.cc View 1 chunk +0 lines, -2 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
scottmg
https://codereview.chromium.org/945713002/diff/1/net/base/url_util.cc File net/base/url_util.cc (left): https://codereview.chromium.org/945713002/diff/1/net/base/url_util.cc#oldcode47 net/base/url_util.cc:47: input.data() + value_range.begin, value_range.len); this one seems a little ...
5 years, 10 months ago (2015-02-20 05:02:06 UTC) #1
Randy Smith (Not in Mondays)
lgtm
5 years, 10 months ago (2015-02-23 14:34:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/945713002/1
5 years, 10 months ago (2015-02-23 16:38:53 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 17:33:32 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:34:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edba32ccb3147b5bc034f44a26d5e886c72f0366
Cr-Commit-Position: refs/heads/master@{#317603}

Powered by Google App Engine
This is Rietveld 408576698