Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: net/base/url_util.cc

Issue 945713002: win vs2015: fix variable shadowing warnings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/upload_file_element_reader.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/url_util.cc
diff --git a/net/base/url_util.cc b/net/base/url_util.cc
index 8540e193d3c53b32bfd3937c81ec4bba744fecda..791f1258fba8ac121cbf93ae74ebb4c8d21a35f0 100644
--- a/net/base/url_util.cc
+++ b/net/base/url_util.cc
@@ -43,8 +43,6 @@ GURL AppendOrReplaceQueryParameter(const GURL& url,
&value_range)) {
const base::StringPiece key(
input.data() + key_range.begin, key_range.len);
- const base::StringPiece value(
- input.data() + value_range.begin, value_range.len);
scottmg 2015/02/20 05:02:06 this one seems a little tricky because it's shadow
std::string key_value_pair;
// Check |replaced| as only the first pair should be replaced.
if (!replaced && key == param_name) {
« no previous file with comments | « net/base/upload_file_element_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698