win vs2015: fix variable shadowing warnings

net/base/url_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/url_util.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/strings/string_piece.h"
@@ skipping 25 matching lines @@
   std::string param_value = EscapeQueryParamValue(value, true);
 
   const std::string input = url.query();
   url::Component cursor(0, input.size());
   std::string output;
   url::Component key_range, value_range;
   while (url::ExtractQueryKeyValue(input.data(), &cursor, &key_range,
                                    &value_range)) {
     const base::StringPiece key(
         input.data() + key_range.begin, key_range.len);
-    const base::StringPiece value(
-        input.data() + value_range.begin, value_range.len);

[scottmg, 2015/02/20 05:02:06]

this one seems a little tricky because it's shadowing a parameter, but as far as
I can see this value is never used.

     std::string key_value_pair;
     // Check |replaced| as only the first pair should be replaced.
     if (!replaced && key == param_name) {
       replaced = true;
       key_value_pair = (param_name + "=" + param_value);
     } else {
       key_value_pair.assign(input.data(),
                             key_range.begin,
                             value_range.end() - key_range.begin);
     }
@@ skipping 70 matching lines @@
   for (QueryIterator it(url); !it.IsAtEnd(); it.Advance()) {
     if (it.GetKey() == search_key) {
       *out_value = it.GetUnescapedValue();
       return true;
     }
   }
   return false;
 }
 
 }  // namespace net