Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 945003002: Remove LayoutState. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove LayoutState. The only bit that was still used was the containingBlockLogicalWidthChanged check in RenderBlock::widthAvailableToChildrenHasChanged. https://chromium.googlesource.com/chromium/blink/+/a4f1e657ff786f80bbc32f0a2af787bc33327e56 is the patch that added that code. I added a test to confirm we still pass the test case that code was added for. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c0901b459c71ef77dfebed5f9580413c7e9817ec

Patch Set 1 #

Patch Set 2 : fix tagnames #

Patch Set 3 : improve test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -263 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
D sky/engine/core/rendering/LayoutState.h View 1 chunk +0 lines, -73 lines 0 comments Download
D sky/engine/core/rendering/LayoutState.cpp View 1 chunk +0 lines, -80 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +1 line, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +17 lines, -23 lines 1 comment Download
M sky/engine/core/rendering/RenderBlockFlow.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 2 chunks +0 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderFlexibleBox.cpp View 1 chunk +10 lines, -14 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 5 chunks +0 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 4 chunks +1 line, -38 lines 0 comments Download
M sky/engine/core/rendering/line/LineLayoutState.h View 1 chunk +1 line, -1 line 0 comments Download
A sky/tests/layout/borderbox-percent-padding.sky View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A + sky/tests/layout/borderbox-percent-padding-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
https://codereview.chromium.org/945003002/diff/40001/sky/engine/core/rendering/RenderBlock.cpp File sky/engine/core/rendering/RenderBlock.cpp (left): https://codereview.chromium.org/945003002/diff/40001/sky/engine/core/rendering/RenderBlock.cpp#oldcode264 sky/engine/core/rendering/RenderBlock.cpp:264: widthAvailableToChildrenHasChanged |= style()->boxSizing() == BORDER_BOX && needsPreferredWidthsRecalculation() && view()->layoutState()->containingBlockLogicalWidthChanged(); ...
5 years, 10 months ago (2015-02-20 20:14:32 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-20 20:16:39 UTC) #3
ojan
5 years, 10 months ago (2015-02-20 22:02:47 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
c0901b459c71ef77dfebed5f9580413c7e9817ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698