Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 944573003: Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (Closed)

Created:
5 years, 10 months ago by hiroshige
Modified:
5 years, 10 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (patchset #18 id:350001 of https://codereview.chromium.org/936193004/) Reason for revert: Suspecting this breaks Mac builds. http://build.chromium.org/p/chromium/builders/Mac/builds/33993 Original issue's description: > add gn_all, gyp_all targets to the build files, remove GN's //:root > > In order to be able to make sure we are building the same list of targets > in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all' > targets. > > Eventually, we should make sure that if one builds 'gn_all', then building > 'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this > is a start. > > The 'gn_all' target replaces the //:root target in the GN builds. > > R=brettw@chromium.org > BUG=461019 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg > > Committed: https://crrev.com/ff30e3de333305ccdaa103aa7f9e46765da83e99 > Cr-Commit-Position: refs/heads/master@{#317760} TBR=brettw@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=461019 Committed: https://crrev.com/e6d374cf7ead69b3ff110f9d7dfba0dee921e6b7 Cr-Commit-Position: refs/heads/master@{#317763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -410 lines) Patch
M BUILD.gn View 4 chunks +243 lines, -224 lines 0 comments Download
M build/all.gyp View 1 chunk +1 line, -150 lines 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +7 lines, -6 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libaddressinput/BUILD.gn View 3 chunks +1 line, -12 lines 0 comments Download
M third_party/libexif/BUILD.gn View 2 chunks +4 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hiroshige
Created Revert of add gn_all, gyp_all targets to build files, remove GN's //:root
5 years, 10 months ago (2015-02-24 07:41:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944573003/1
5 years, 10 months ago (2015-02-24 07:53:43 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 07:54:12 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6d374cf7ead69b3ff110f9d7dfba0dee921e6b7 Cr-Commit-Position: refs/heads/master@{#317763}
5 years, 10 months ago (2015-02-24 07:54:41 UTC) #5
Dirk Pranke
5 years, 10 months ago (2015-02-24 15:45:31 UTC) #6
Message was sent while issue was closed.
On 2015/02/24 07:54:41, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e6d374cf7ead69b3ff110f9d7dfba0dee921e6b7
> Cr-Commit-Position: refs/heads/master@{#317763}

lgtm, thanks for taking care of this!

Powered by Google App Engine
This is Rietveld 408576698