build/secondary/tools/grit/grit_rule.gni - Issue 944573003: Revert of add gn_all, gyp_all targets to build files, remove GN's //:root

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 944573003: Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index 626fd745d8a9dc505b59cd4a10ad7951de1def18..cdaf0f272282f693ecd36763f2cae92f8e275097 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -53,8 +53,6 @@

# use_qualified_include (optional)

# If set, output_dir is not added to include_dirs.

-# configs (optional)

-# List of additional configs to be applied to the generated target.

# deps (optional)

# inputs (optional)

# List of additional files, required for grit to process source file.

@@ -440,10 +438,6 @@

public_configs += invoker.public_configs

}

- if (defined(invoker.configs)) {

- configs += invoker.configs

- }

if (defined(invoker.visibility)) {

visibility = invoker.visibility

}

« no previous file with comments | « build/all.gyp ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »