Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: third_party/libaddressinput/BUILD.gn

Issue 944573003: Revert of add gn_all, gyp_all targets to build files, remove GN's //:root (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pdf/renderer/BUILD.gn ('k') | third_party/libexif/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libaddressinput/BUILD.gn
diff --git a/third_party/libaddressinput/BUILD.gn b/third_party/libaddressinput/BUILD.gn
index 1307c7163699f581d7f275f0c205ab18df73e0ce..0c92b5babd60ac15a4365bb5c5c3306a8f1dc493 100644
--- a/third_party/libaddressinput/BUILD.gn
+++ b/third_party/libaddressinput/BUILD.gn
@@ -23,12 +23,6 @@
"src/cpp/src/util/string_split.cc",
"src/cpp/src/util/string_util.cc",
]
-
-config("no-newline-eof-warning") {
- if (is_clang) {
- cflags = [ "-Wno-newline-eof" ]
- }
-}
# GYP version: third_party/libaddressinput/libaddressinput.gyp:libaddressinput_strings
grit("strings") {
@@ -91,8 +85,6 @@
"address_input_strings_zh-CN.pak",
"address_input_strings_zh-TW.pak",
]
-
- configs = [ ":no-newline-eof-warning" ]
}
config("libaddressinput_config") {
@@ -117,10 +109,7 @@
sources -= [ "src/cpp/src/util/json.cc" ]
configs -= [ "//build/config/compiler:chromium_code" ]
- configs += [
- ":no-newline-eof-warning",
- "//build/config/compiler:no_chromium_code",
- ]
+ configs += [ "//build/config/compiler:no_chromium_code" ]
public_configs = [ ":libaddressinput_config" ]
« no previous file with comments | « components/pdf/renderer/BUILD.gn ('k') | third_party/libexif/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698