Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 944533004: Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow (Closed)

Created:
5 years, 10 months ago by tapted
Modified:
5 years, 10 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow InfoBubbleWindow overrides -[NSWindow close] to schedule a fade animation instead of closing. Currently, BaseBubbleController calls this, but first removes the bubble from its parent NSWindow. This means that if the close is due to a click on a browser window, the parent->child relationship is already gone, and the clicked window is raised on top of the bubble, making it seem to disappear immediately rather than fade out. This changes the flow so that InfoBubbleWindow only removes itself as a child before calling [super close]; once the animation is complete. BUG=459881 Committed: https://crrev.com/c780b64584b33eb0f045fbda5c9b4c2ccd4c8815 Cr-Commit-Position: refs/heads/master@{#317962}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/base_bubble_controller.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/info_bubble_window.mm View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
whoops - forgot to click publish. robert - please take a look. (no rush) Thanks!
5 years, 10 months ago (2015-02-24 22:23:49 UTC) #2
Robert Sesek
LGTM
5 years, 10 months ago (2015-02-25 01:38:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/944533004/1
5 years, 10 months ago (2015-02-25 01:58:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 03:10:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 03:10:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c780b64584b33eb0f045fbda5c9b4c2ccd4c8815
Cr-Commit-Position: refs/heads/master@{#317962}

Powered by Google App Engine
This is Rietveld 408576698