DescriptionMac: Make bubble windows (not their controller) responsible for calling removeChildWindow
InfoBubbleWindow overrides -[NSWindow close] to schedule a fade
animation instead of closing. Currently, BaseBubbleController calls
this, but first removes the bubble from its parent NSWindow. This means
that if the close is due to a click on a browser window, the
parent->child relationship is already gone, and the clicked window is
raised on top of the bubble, making it seem to disappear immediately
rather than fade out.
This changes the flow so that InfoBubbleWindow only removes itself as a
child before calling [super close]; once the animation is complete.
BUG=459881
Committed: https://crrev.com/c780b64584b33eb0f045fbda5c9b4c2ccd4c8815
Cr-Commit-Position: refs/heads/master@{#317962}
Patch Set 1 #
Messages
Total messages: 7 (2 generated)
|