chrome/browser/ui/cocoa/base_bubble_controller.mm - Issue 944533004: Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 944533004: Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/base_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm

index c4f4cf19d93c9fb162300f13fa7923bc4213a0a7..c8ca24ceb8e9ee0ab1f03a2514bad677968b67f4 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm

@@ -202,9 +202,6 @@

}

tabStripObserverBridge_.reset();

- NSWindow* window = [self window];

- [[window parentWindow] removeChildWindow:window];

}

- (void)windowWillClose:(NSNotification*)notification {

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/info_bubble_window.mm » ('j') | no next file with comments »