chrome/browser/ui/cocoa/info_bubble_window.mm - Issue 944533004: Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/info_bubble_window.mm

Issue 944533004: Mac: Make bubble windows (not their controller) responsible for calling removeChildWindow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/info_bubble_window.mm

diff --git a/chrome/browser/ui/cocoa/info_bubble_window.mm b/chrome/browser/ui/cocoa/info_bubble_window.mm

index d4bff5d45190efbf3a0aea9cc8eb5ba57c9c39e5..4c33cac25633f86abae8139cff8393a54e3a101c 100644

--- a/chrome/browser/ui/cocoa/info_bubble_window.mm

+++ b/chrome/browser/ui/cocoa/info_bubble_window.mm

@@ -185,8 +185,10 @@ class AppNotificationBridge : public content::NotificationObserver {

// Called by InfoBubbleWindowCloser when the window is to be really closed

// after the fading animation is complete.

- (void)finishCloseAfterAnimation {

- if (closing_)

+ if (closing_) {

+ [[self parentWindow] removeChildWindow:self];

[super close];

+ }

}

// Adds animation for info bubbles being ordered to the front.

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.mm ('k') | no next file » | no next file with comments »