Add HWUI Sink to DM on Android Framework builds

Add HWUI Sink to DM on Android Framework builds

Allows "hwui" as a --config argument to dm, drawing through the Android
Framework's HWUI backend.

R=djsollen@google.com,mtklein@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/eebc39ad5a1dcbde1b10a9b2ab54679549522b52

[tomhudson, 2015-02-23 16:23:42]

These are the changes we've been hashing out for Android, and should be about
ready to land in Skia; PTAL.

[djsollen, 2015-02-23 16:30:19]

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp
File dm/DMSrcSinkAndroid.cpp (right):

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:15: #include "android/rect.h"
do we need all of these includes?

[mtklein, 2015-02-23 16:46:09]

lgtm

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp
File dm/DMSrcSinkAndroid.cpp (right):

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:27: /* These functions are only compiled in the Android
Framework. */
Might wrap everything with #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK to move this
assertion from comment to code.

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:143: return SkStringPrintf("Failed to wrap HWUI buffer
in a SkBitmap");
This is fine, but without parameters, you can also just return "Failed to wrap
HWUI buffer in an SkBitmap.";

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:151: return SkStringPrintf("Failed to extract pixels
from HWUI buffer");
Ditto.

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.h
File dm/DMSrcSinkAndroid.h (right):

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.h#newcode17
dm/DMSrcSinkAndroid.h:17:
/*~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~*/
These can probably go.   There's only one section in here.  :)

[tomhudson, 2015-02-23 17:43:21]

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp
File dm/DMSrcSinkAndroid.cpp (right):

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:15: #include "android/rect.h"
On 2015/02/23 16:30:19, djsollen wrote:
> do we need all of these includes?

Approximately yes; I've tried removing those that aren't obviously required. In
past personal projects I've occasionally notated #includes with why, but that
isn't part of our style; I can do that if it helps here.

(There may be some of these headers that are indirectly included by other
headers on the list, but I don't like relying on that.)

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:27: /* These functions are only compiled in the Android
Framework. */
On 2015/02/23 16:46:09, mtklein wrote:
> Might wrap everything with #ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK to move this
> assertion from comment to code.

I'm torn between doing that, which is redundant with the .gyp file, and just
having this here because the gyp configuration is remote and therefore magic.

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:143: return SkStringPrintf("Failed to wrap HWUI buffer
in a SkBitmap");
On 2015/02/23 16:46:09, mtklein wrote:
> This is fine, but without parameters, you can also just return "Failed to wrap
> HWUI buffer in an SkBitmap.";

Done. (Good catch; there used to be parameters.)

https://codereview.chromium.org/943393002/diff/1/dm/DMSrcSinkAndroid.cpp#newc...
dm/DMSrcSinkAndroid.cpp:151: return SkStringPrintf("Failed to extract pixels
from HWUI buffer");
On 2015/02/23 16:46:09, mtklein wrote:
> Ditto.

Done.

[tomhudson, 2015-02-23 17:43:47]

New patchsets have been uploaded after l-g-t-m from mtklein@google.com

[tomhudson, 2015-02-23 19:18:23]

The CQ bit was checked by tomhudson@google.com

[commit-bot: I haz the power, 2015-02-23 19:18:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/943393002/20001

[commit-bot: I haz the power, 2015-02-23 20:18:09]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eebc39ad5a1dcbde1b10a9b2ab54679549522b52