Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 943233002: don't mix system and bundled ICU (Closed)

Created:
5 years, 10 months ago by Mostyn Bramley-Moore
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

don't mix system and bundled ICU The ICU 54.1 upgrade added a call to uloc_getDefault() to base/test/test_suite.cc, but did not add a libicuuc dependency to the corresponding gyp/gn targets. This makes it possible to mix system and bundled ICU headers (and will fail to build if they differ in version). BUG=428145 Committed: https://crrev.com/18f4375774ff56b72896a5b0b792b753ae4ef584 Cr-Commit-Position: refs/heads/master@{#317616}

Patch Set 1 #

Patch Set 2 : fix the gn build also #

Patch Set 3 : add another missing icuuc dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M base/test/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Mostyn Bramley-Moore
@Mark, Jungshik: please take a look at this small fixup after https://codereview.chromium.org/878723002.
5 years, 10 months ago (2015-02-22 10:44:05 UTC) #2
Mostyn Bramley-Moore
I spotted another source file, whose target was missing the icuuc dep: extensions/common/extension_l10n_util.cc
5 years, 10 months ago (2015-02-22 15:04:16 UTC) #3
Mark Mentovai
LGTM
5 years, 10 months ago (2015-02-23 16:31:24 UTC) #4
Mostyn Bramley-Moore
@Ken: can you take a look at the extensions/extensions.gyp change?
5 years, 10 months ago (2015-02-23 17:08:44 UTC) #6
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-23 17:26:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/943233002/40001
5 years, 10 months ago (2015-02-23 17:27:15 UTC) #9
jungshik at Google
LGTM. Thanks
5 years, 10 months ago (2015-02-23 17:49:22 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-23 19:02:49 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:03:45 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/18f4375774ff56b72896a5b0b792b753ae4ef584
Cr-Commit-Position: refs/heads/master@{#317616}

Powered by Google App Engine
This is Rietveld 408576698