base/base.gyp - Issue 943233002: don't mix system and bundled ICU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gyp

Issue 943233002: don't mix system and bundled ICU (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add another missing icuuc dep Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base.gyp

diff --git a/base/base.gyp b/base/base.gyp

index 213e62d9e968ea727e04b5b3f20bfef4edc03a45..5eff44734e7ee9983765685228eeb3d98756488f 100644

--- a/base/base.gyp

+++ b/base/base.gyp

@@ -876,6 +876,7 @@

'base_i18n',

'../testing/gmock.gyp:gmock',

'../testing/gtest.gyp:gtest',

+ '../third_party/icu/icu.gyp:icuuc',

'../third_party/libxml/libxml.gyp:libxml',

'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',

« no previous file with comments | « no previous file | base/test/BUILD.gn » ('j') | no next file with comments »