Chromium Code Reviews Chromium Code Reviews
Issue
878723002:
Upgrade ICU to 54.1 (Closed)
DescriptionUpgrade ICU to 54.1
ICU 54.1 comes with CLDR 26 locale data along with Lao and Khmer dictionaries
for line/word breaking, new interval/duration formatting support, display
context support for date-time and lang/region display name and many more.
To better support regional variants such as en-{CA,AU}, fr-CA, es-*, and de-CH,
the locale data for those variants are included.
The ICU data file (icudtl.dat) for non-Android platform is
256,960 bytes smaller than before.
On Android, it's 232,240 bytes larger because the currency display
name data was added for EcmaScript I18N API.
On Linux/Mac/Android/iOS, base::TestSuites initializer now sets the
ICU locale explicitly to en_US if the default locale is a POSIX locale
that is not supported because I got rid of word_POSIX to save about
100kB. Moreover, virtually none of our users uses a POSIX locale so that
testing on POSIX locale is not realistic.
en_GB time formatting changed in ICU 54.1/CLDR 26 and the expected results
are updated.
Noto to Sheriff: The above data size changes (reduction or increase) may
require the expected size adjustment.
See https://codereview.chromium.org/403723003 for a similar change.
BUG=428145
TEST=All tests on all platforms including but not limited to
1. Blink: layout tests and webkit_unittests
1. base_unittests: Break*, *onvers*, *Format*, *CU*, RTL*, *Search*
2. browser_tests: *ncoding*, *UILanguage* (CrOS)
3. sql_unittests
4. gfx_unittests: RenderText*
5. components_unittests: Query*, *ookmark*
6. net_unittests: Net**IDN*, URL*
7. url_unittests
8. ui_base_unittests
Committed: https://crrev.com/8fe2fe9afd2d94f6cd814cd55900460ad11da26a
Cr-Commit-Position: refs/heads/master@{#317210}
Patch Set 1 #Patch Set 2 : add BUILD.gn and roll icu to the latest revision #Patch Set 3 : update the expected results for time format in en-GB #Patch Set 4 : rebase #Patch Set 5 : fix sql/gfx/component*tests on Mac #Patch Set 6 : overrides posix locale on all platforms #Patch Set 7 : posix locale overide: only on Mac/Linux. iOS can't find ICU header uenum.h #Patch Set 8 : exclude IOS from icu locale set codepath #Patch Set 9 : suppress regional variants for now (cros browsertest) #Patch Set 10 : add back POSIX locale override on iOS #Patch Set 11 : style fix #Patch Set 12 : almost back to ps 6 for posix loale check/override #Patch Set 13 : set icu locale to en_US unconditionally on iOS test #Patch Set 14 : windows link fix for icuuc #Patch Set 15 : fix ios link issue (icudata type is now none) #Patch Set 16 : fix en_GB lang display name #Patch Set 17 : add en-GB display name test #
Messages
Total messages: 39 (16 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
