clear stencil buffer using special purpose FBO

clear stencil buffer using special purpose FBO

Committed: https://skia.googlesource.com/skia/+/dd3143b0079f01980ca4886f00c39b3caa3fee6a

[bsalomon, 2015-02-20 20:56:55]

bsalomon@google.com changed reviewers:
+ egdaniel@google.com, robertphillips@google.com

[egdaniel, 2015-02-20 22:24:07]

https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp#newco...
src/gpu/gl/GrGLGpu.cpp:1194: fHWBoundRenderTargetUniqueID = 0;
we use Sk_InvalidEnum in this file instead of 0 for fHWBRTUID

[bsalomon, 2015-02-20 22:27:17]

https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp#newco...
src/gpu/gl/GrGLGpu.cpp:1194: fHWBoundRenderTargetUniqueID = 0;
On 2015/02/20 22:24:07, egdaniel wrote:
> we use Sk_InvalidEnum in this file instead of 0 for fHWBRTUID

Done.

[robertphillips, 2015-02-23 14:47:11]

lgtm

[bsalomon, 2015-02-23 16:34:30]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-23 16:34:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941383003/20001

[commit-bot: I haz the power, 2015-02-23 16:34:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-23 16:34:57]

Failed to apply patch for src/gpu/GrGpu.cpp:
While running git apply --index -3 -p1;
  error: patch failed: src/gpu/GrGpu.cpp:97
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: src/gpu/GrGpu.cpp: patch does not apply

Patch:       src/gpu/GrGpu.cpp
Index: src/gpu/GrGpu.cpp
diff --git a/src/gpu/GrGpu.cpp b/src/gpu/GrGpu.cpp
index
efe1a618e6a8ebe9961243e7b32e1f94fb095940..df8de57b94095577ef26f723b9777f00a24dad4c
100644
--- a/src/gpu/GrGpu.cpp
+++ b/src/gpu/GrGpu.cpp
@@ -97,15 +97,6 @@ bool GrGpu::attachStencilBufferToRenderTarget(GrRenderTarget*
rt) {
         return false;
     }
     if (this->createStencilBufferForRenderTarget(rt, width, height)) {
-        // Right now we're clearing the stencil buffer here after it is
-        // attached to an RT for the first time. When we start matching
-        // stencil buffers with smaller color targets this will no longer
-        // be correct because it won't be guaranteed to clear the entire
-        // sb.
-        // We used to clear down in the GL subclass using a special purpose
-        // FBO. But iOS doesn't allow a stencil-only FBO. It reports
unsupported
-        // FBO status.
-        this->clearStencil(rt);
         GrStencilBuffer* sb = rt->renderTargetPriv().getStencilBuffer();
         sb->resourcePriv().setUniqueKey(sbKey);
         return true;

[bsalomon, 2015-02-23 17:07:00]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2015-02-23 17:07:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/941383003/20001

[commit-bot: I haz the power, 2015-02-23 17:27:50]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dd3143b0079f01980ca4886f00c39b3caa3fee6a