Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 941383003: clear stencil buffer using special purpose FBO (Closed)

Created:
5 years, 10 months ago by bsalomon
Modified:
5 years, 10 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@diff_clip
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clear stencil buffer using special purpose FBO Committed: https://skia.googlesource.com/skia/+/dd3143b0079f01980ca4886f00c39b3caa3fee6a

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M src/gpu/GrGpu.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 4 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
bsalomon
5 years, 10 months ago (2015-02-20 20:56:56 UTC) #2
egdaniel
https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp#newcode1194 src/gpu/gl/GrGLGpu.cpp:1194: fHWBoundRenderTargetUniqueID = 0; we use Sk_InvalidEnum in this file ...
5 years, 10 months ago (2015-02-20 22:24:07 UTC) #3
bsalomon
https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp File src/gpu/gl/GrGLGpu.cpp (right): https://codereview.chromium.org/941383003/diff/1/src/gpu/gl/GrGLGpu.cpp#newcode1194 src/gpu/gl/GrGLGpu.cpp:1194: fHWBoundRenderTargetUniqueID = 0; On 2015/02/20 22:24:07, egdaniel wrote: > ...
5 years, 10 months ago (2015-02-20 22:27:17 UTC) #4
robertphillips
lgtm
5 years, 10 months ago (2015-02-23 14:47:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941383003/20001
5 years, 10 months ago (2015-02-23 16:34:54 UTC) #7
commit-bot: I haz the power
Failed to apply patch for src/gpu/GrGpu.cpp: While running git apply --index -3 -p1; error: patch ...
5 years, 10 months ago (2015-02-23 16:34:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/941383003/20001
5 years, 10 months ago (2015-02-23 17:07:59 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:27:50 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/dd3143b0079f01980ca4886f00c39b3caa3fee6a

Powered by Google App Engine
This is Rietveld 408576698