Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6188)

Unified Diff: chrome/browser/ui/views/global_error_bubble_view.h

Issue 941133002: Update global error bubble view's boundary (position and size) after loading elevation icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/global_error_bubble_view.h
diff --git a/chrome/browser/ui/views/global_error_bubble_view.h b/chrome/browser/ui/views/global_error_bubble_view.h
index 33ab6ce2c0ca22f39542f8281d831cfadf971b55..5632d24f5bfbef6f3dbe4dfe8a044716bae4cb0c 100644
--- a/chrome/browser/ui/views/global_error_bubble_view.h
+++ b/chrome/browser/ui/views/global_error_bubble_view.h
@@ -14,9 +14,11 @@ class Browser;
class ElevationIconSetter;
class GlobalErrorWithStandardBubble;
-class GlobalErrorBubbleView : public views::ButtonListener,
- public views::BubbleDelegateView,
- public GlobalErrorBubbleViewBase {
+class GlobalErrorBubbleView
+ : public views::ButtonListener,
+ public views::BubbleDelegateView,
+ public base::SupportsWeakPtr<GlobalErrorBubbleView>,
Peter Kasting 2015/02/23 21:26:48 There's no need for any of the classes in this CL
xiaoling 2015/02/23 21:50:04 Done.
+ public GlobalErrorBubbleViewBase {
public:
GlobalErrorBubbleView(
views::View* anchor_view,

Powered by Google App Engine
This is Rietveld 408576698