chrome/browser/ui/views/infobars/confirm_infobar.cc - Issue 941133002: Update global error bubble view's boundary (position and size) after loading elevation icon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/infobars/confirm_infobar.cc

Issue 941133002: Update global error bubble view's boundary (position and size) after loading elevation icon. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/global_error_bubble_view.h ('K') | « chrome/browser/ui/views/infobars/confirm_infobar.h ('k') | chrome/browser/ui/views/outdated_upgrade_bubble_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/infobars/confirm_infobar.cc

diff --git a/chrome/browser/ui/views/infobars/confirm_infobar.cc b/chrome/browser/ui/views/infobars/confirm_infobar.cc

index b1770353c9d3c26e75520d3455b25dcc006150b7..7e335a2517517e0bfc81e157728421962a3df45b 100644

--- a/chrome/browser/ui/views/infobars/confirm_infobar.cc

+++ b/chrome/browser/ui/views/infobars/confirm_infobar.cc

@@ -71,7 +71,9 @@ void ConfirmInfoBar::ViewHierarchyChanged(

ok_button_ = CreateLabelButton(

this, delegate->GetButtonLabel(ConfirmInfoBarDelegate::BUTTON_OK));

if (delegate->OKButtonTriggersUACPrompt())

- elevation_icon_setter_.reset(new ElevationIconSetter(ok_button_));

+ elevation_icon_setter_.reset(new ElevationIconSetter(

+ ok_button_,

+ base::Bind(&ConfirmInfoBar::InvalidateLayout, AsWeakPtr())));

Peter Kasting 2015/02/23 21:26:48 I would bind to Layout() rather than InvalidateLay

xiaoling 2015/02/23 21:50:04 Done.

AddChildView(ok_button_);

}