Update global error bubble view's boundary (position and size) after loading elevation icon.

chrome/browser/ui/views/global_error_bubble_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_GLOBAL_ERROR_BUBBLE_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_GLOBAL_ERROR_BUBBLE_VIEW_H_
 
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/ui/global_error/global_error_bubble_view_base.h"
 #include "ui/views/bubble/bubble_delegate.h"
 #include "ui/views/controls/button/button.h"
 
 class Browser;
 class ElevationIconSetter;
 class GlobalErrorWithStandardBubble;
 
-class GlobalErrorBubbleView : public views::ButtonListener,
-                              public views::BubbleDelegateView,
-                              public GlobalErrorBubbleViewBase {
+class GlobalErrorBubbleView
+    : public views::ButtonListener,
+      public views::BubbleDelegateView,
+      public base::SupportsWeakPtr<GlobalErrorBubbleView>,

[Peter Kasting, 2015/02/23 21:26:48]

There's no need for any of the classes in this CL to subclass SupportsWeakPtr
and bind the closures to weak pointers.  These classes own the
ElevationIconSetters, so if they're destroyed, the setters will also be
destroyed and can't call back.  (That's why ElevationIconSetter uses a weak
pointer internally for thread-hopping.)  So you can bind all these as
Unretained.

[xiaoling, 2015/02/23 21:50:04]

Done.

+      public GlobalErrorBubbleViewBase {
  public:
   GlobalErrorBubbleView(
       views::View* anchor_view,
       views::BubbleBorder::Arrow arrow,
       Browser* browser,
       const base::WeakPtr<GlobalErrorWithStandardBubble>& error);
   ~GlobalErrorBubbleView() override;
 
   // views::ButtonListener implementation.
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
@@ skipping 10 matching lines @@
  private:
   Browser* browser_;
   base::WeakPtr<GlobalErrorWithStandardBubble> error_;
 
   scoped_ptr<ElevationIconSetter> elevation_icon_setter_;
 
   DISALLOW_COPY_AND_ASSIGN(GlobalErrorBubbleView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_GLOBAL_ERROR_BUBBLE_VIEW_H_