Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 940813003: Use a utility process for the Mojo v8 proxy resolver. (Closed)

Created:
5 years, 10 months ago by Anand Mistry (off Chromium)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@v8-pac-in-process-enable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a utility process for the Mojo v8 proxy resolver. A single utility process is used for all proxy resolvers. If the process is killed, a new one will be created. BUG=11746 Committed: https://crrev.com/467cdc7fc7bfb78b37066851023c833a55eacd0a Cr-Commit-Position: refs/heads/master@{#320430}

Patch Set 1 #

Patch Set 2 : Handle utility process creation failure. #

Patch Set 3 : Rebase, make utility process creation lazy, and handle process restart differently. #

Patch Set 4 : Rebase and fix gyp. #

Patch Set 5 : Rebase #

Patch Set 6 : Add browser test #

Total comments: 6

Patch Set 7 : Address review comments. #

Total comments: 25

Patch Set 8 : Address some review comments. #

Total comments: 8

Patch Set 9 : Rebase. #

Patch Set 10 : Address review comments. #

Total comments: 2

Patch Set 11 : Remove unneeded forward decl. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -5 lines) Patch
M chrome/browser/net/proxy_browsertest.cc View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/net/proxy_service_factory.cc View 1 2 3 4 5 6 7 3 chunks +10 lines, -1 line 0 comments Download
A chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h View 1 2 3 4 5 6 7 8 9 10 1 chunk +45 lines, -0 lines 0 comments Download
A chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc View 1 2 3 4 5 6 7 1 chunk +70 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_utility.gypi View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 5 6 7 8 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/utility/BUILD.gn View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 2 3 4 5 6 7 4 chunks +21 lines, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.h View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 1 2 3 4 5 6 7 8 9 6 chunks +40 lines, -4 lines 0 comments Download
M content/public/browser/utility_process_host.h View 1 2 3 4 5 6 7 3 chunks +11 lines, -0 lines 0 comments Download
M content/public/utility/content_utility_client.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (3 generated)
Anand Mistry (off Chromium)
eroman@chromium.org: Please review changes in *net* avi@chromium.org: Please review changes in content/ thestig@chromium.org: Please review ...
5 years, 9 months ago (2015-03-03 05:18:02 UTC) #2
Lei Zhang
https://codereview.chromium.org/940813003/diff/100001/chrome/utility/BUILD.gn File chrome/utility/BUILD.gn (right): https://codereview.chromium.org/940813003/diff/100001/chrome/utility/BUILD.gn#newcode31 chrome/utility/BUILD.gn:31: "//net:net_utility_services", I'm suspicious when you make this change here, ...
5 years, 9 months ago (2015-03-03 07:50:02 UTC) #3
Avi (use Gerrit)
On 2015/03/03 05:18:02, Anand Mistry wrote: > mailto:eroman@chromium.org: Please review changes in *net* > > ...
5 years, 9 months ago (2015-03-03 16:14:35 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/940813003/diff/100001/chrome/utility/BUILD.gn File chrome/utility/BUILD.gn (right): https://codereview.chromium.org/940813003/diff/100001/chrome/utility/BUILD.gn#newcode31 chrome/utility/BUILD.gn:31: "//net:net_utility_services", On 2015/03/03 07:50:02, Lei Zhang wrote: > I'm ...
5 years, 9 months ago (2015-03-05 05:11:02 UTC) #5
Lei Zhang
https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_service_factory.cc File chrome/browser/net/proxy_service_factory.cc (right): https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_service_factory.cc#newcode161 chrome/browser/net/proxy_service_factory.cc:161: { Our cpp linter does not like this. How ...
5 years, 9 months ago (2015-03-05 23:42:49 UTC) #6
eroman
https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc (right): https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc#newcode39 chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc:39: content::UtilityProcessHost::Create( What is the lifetime of this process? It ...
5 years, 9 months ago (2015-03-06 05:48:21 UTC) #7
Sam McNally
https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_browsertest.cc File chrome/browser/net/proxy_browsertest.cc (right): https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_browsertest.cc#newcode265 chrome/browser/net/proxy_browsertest.cc:265: command_line->AppendSwitchASCII(switches::kProxyPacUrl, Wrap after ( or align the next line ...
5 years, 9 months ago (2015-03-09 03:36:16 UTC) #8
Anand Mistry (off Chromium)
https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_browsertest.cc File chrome/browser/net/proxy_browsertest.cc (right): https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/proxy_browsertest.cc#newcode265 chrome/browser/net/proxy_browsertest.cc:265: command_line->AppendSwitchASCII(switches::kProxyPacUrl, On 2015/03/09 03:36:15, Sam McNally wrote: > Wrap ...
5 years, 9 months ago (2015-03-10 07:24:24 UTC) #9
eroman
https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc (right): https://codereview.chromium.org/940813003/diff/120001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc#newcode39 chrome/browser/net/utility_process_mojo_proxy_resolver_factory.cc:39: content::UtilityProcessHost::Create( On 2015/03/10 07:24:23, Anand Mistry wrote: > On ...
5 years, 9 months ago (2015-03-11 18:48:36 UTC) #10
Anand Mistry (off Chromium)
https://codereview.chromium.org/940813003/diff/140001/content/browser/utility_process_host_impl.cc File content/browser/utility_process_host_impl.cc (right): https://codereview.chromium.org/940813003/diff/140001/content/browser/utility_process_host_impl.cc#newcode118 content/browser/utility_process_host_impl.cc:118: // the Mojo channel doesn't get the oppertunity to ...
5 years, 9 months ago (2015-03-12 05:10:22 UTC) #11
Sam McNally
LGTM https://codereview.chromium.org/940813003/diff/180001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h (right): https://codereview.chromium.org/940813003/diff/180001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h#newcode15 chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h:15: class UtilityProcessHost; Remove.
5 years, 9 months ago (2015-03-12 06:26:23 UTC) #12
eroman
lgtm
5 years, 9 months ago (2015-03-12 19:36:01 UTC) #13
Anand Mistry (off Chromium)
Lei: Ping! https://codereview.chromium.org/940813003/diff/180001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h File chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h (right): https://codereview.chromium.org/940813003/diff/180001/chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h#newcode15 chrome/browser/net/utility_process_mojo_proxy_resolver_factory.h:15: class UtilityProcessHost; On 2015/03/12 06:26:23, Sam McNally ...
5 years, 9 months ago (2015-03-12 23:01:11 UTC) #14
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-12 23:13:35 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940813003/200001
5 years, 9 months ago (2015-03-12 23:22:47 UTC) #18
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 9 months ago (2015-03-13 01:58:55 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 02:00:13 UTC) #20
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/467cdc7fc7bfb78b37066851023c833a55eacd0a
Cr-Commit-Position: refs/heads/master@{#320430}

Powered by Google App Engine
This is Rietveld 408576698