Use a utility process for the Mojo v8 proxy resolver.

content/browser/utility_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/utility_process_host_impl.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/message_loop/message_loop.h"
+#include "base/process/process_handle.h"
 #include "base/run_loop.h"
 #include "base/sequenced_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock.h"
 #include "base/synchronization/waitable_event.h"
 #include "content/browser/browser_child_process_host_impl.h"
+#include "content/browser/mojo/mojo_application_host.h"
 #include "content/browser/renderer_host/render_process_host_impl.h"
 #include "content/common/child_process_host_impl.h"
 #include "content/common/utility_messages.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/content_browser_client.h"
 #include "content/public/browser/utility_process_host_client.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/process_type.h"
 #include "content/public/common/sandboxed_process_launcher_delegate.h"
 #include "ipc/ipc_switches.h"
 #include "ui/base/ui_base_switches.h"
 
 namespace content {
 
 // NOTE: changes to this class need to be reviewed by the security team.
 class UtilitySandboxedProcessLauncherDelegate
     : public SandboxedProcessLauncherDelegate {
  public:
   UtilitySandboxedProcessLauncherDelegate(const base::FilePath& exposed_dir,
-                                          bool launch_elevated, bool no_sandbox,
+                                          bool launch_elevated,
+                                          bool no_sandbox,
                                           const base::EnvironmentMap& env,
                                           ChildProcessHost* host)
       : exposed_dir_(exposed_dir),
 #if defined(OS_WIN)
         launch_elevated_(launch_elevated)
 #elif defined(OS_POSIX)
         env_(env),
         no_sandbox_(no_sandbox),
         ipc_fd_(host->TakeClientFileDescriptor())
 #endif  // OS_WIN
   {}
 
   ~UtilitySandboxedProcessLauncherDelegate() override {}
 
 #if defined(OS_WIN)
-  bool ShouldLaunchElevated() override {
-    return launch_elevated_;
-  }
+  bool ShouldLaunchElevated() override { return launch_elevated_; }
   void PreSandbox(bool* disable_default_policy,
                   base::FilePath* exposed_dir) override {
     *exposed_dir = exposed_dir_;
   }
 #elif defined(OS_POSIX)
 
   bool ShouldUseZygote() override {
     return !no_sandbox_ && exposed_dir_.empty();
   }
   base::EnvironmentMap GetEnvironment() override { return env_; }
@@ skipping 39 matching lines @@
 #else
       child_flags_(ChildProcessHost::CHILD_NORMAL),
 #endif
       started_(false) {
 }
 
 UtilityProcessHostImpl::~UtilityProcessHostImpl() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   if (is_batch_mode_)
     EndBatchMode();
+
+  // We could be destroyed as a result of Chrome shutdown. When that happens,
+  // the Mojo channel doesn't get the oppertunity to shut down cleanly becuase

[eroman, 2015/03/11 18:48:36]

oppertunity --> opportunity
becuase --> because

[Anand Mistry (off Chromium), 2015/03/12 05:10:22]

Maybe aspell should be part of the PRESUBMIT check :P

+  // it posts to the IO thread (the current thread) which is being destroyed.
+  // To guarantee proper shutdown of the Mojo channel, we do it explicitly here.

[eroman, 2015/03/11 18:48:36]

Note: Use of "we" is something chromium tries to avoid in comments (or at least
I remember several style thread about this).

[Anand Mistry (off Chromium), 2015/03/12 05:10:22]

Done. And noted for the future.

+  if (mojo_application_host_)
+    mojo_application_host_->ShutdownOnIOThread();
 }
 
 bool UtilityProcessHostImpl::Send(IPC::Message* message) {
   if (!StartProcess())
     return false;
 
   return process_->Send(message);
 }
 
 bool UtilityProcessHostImpl::StartBatchMode()  {
@@ skipping 33 matching lines @@
 }
 
 #if defined(OS_POSIX)
 
 void UtilityProcessHostImpl::SetEnv(const base::EnvironmentMap& env) {
   env_ = env;
 }
 
 #endif  // OS_POSIX
 
+bool UtilityProcessHostImpl::StartMojoMode() {
+  CHECK(!mojo_application_host_);
+  mojo_application_host_.reset(new MojoApplicationHost);
+
+  bool mojo_result = mojo_application_host_->Init();
+  if (!mojo_result)
+    return false;
+
+  return StartProcess();
+}
+
+ServiceRegistry* UtilityProcessHostImpl::GetServiceRegistry() {
+  DCHECK(mojo_application_host_);
+  return mojo_application_host_->service_registry();
+}
+
 bool UtilityProcessHostImpl::StartProcess() {
   if (started_)
     return true;
   started_ = true;
 
   if (is_batch_mode_)
     return true;
 
   // Name must be set or metrics_service will crash in any test which
   // launches a UtilityProcessHost.
@@ skipping 107 matching lines @@
 void UtilityProcessHostImpl::OnProcessCrashed(int exit_code) {
   if (!client_.get())
     return;
 
   client_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&UtilityProcessHostClient::OnProcessCrashed, client_.get(),
             exit_code));
 }
 
+void UtilityProcessHostImpl::OnProcessLaunched() {
+  if (mojo_application_host_) {
+    base::ProcessHandle handle;
+    if (RenderProcessHost::run_renderer_in_process())
+      handle = base::GetCurrentProcessHandle();
+    else
+      handle = process_->GetData().handle;
+
+    mojo_application_host_->Activate(this, handle);
+  }
+}
+
 }  // namespace content