Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Side by Side Diff: content/public/browser/utility_process_host.h

Issue 940813003: Use a utility process for the Mojo v8 proxy resolver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v8-pac-in-process-enable
Patch Set: Address review comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_
6 #define CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_ 6 #define CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_
7 7
8 #include "base/environment.h" 8 #include "base/environment.h"
9 #include "base/process/launch.h" 9 #include "base/process/launch.h"
10 #include "base/threading/thread.h" 10 #include "base/threading/thread.h"
11 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
12 #include "ipc/ipc_sender.h" 12 #include "ipc/ipc_sender.h"
13 13
14 namespace base { 14 namespace base {
15 class FilePath; 15 class FilePath;
16 class SequencedTaskRunner; 16 class SequencedTaskRunner;
17 } 17 }
18 18
19 namespace content { 19 namespace content {
20 class ServiceRegistry;
20 class UtilityProcessHostClient; 21 class UtilityProcessHostClient;
21 struct ChildProcessData; 22 struct ChildProcessData;
22 23
23 // This class acts as the browser-side host to a utility child process. A 24 // This class acts as the browser-side host to a utility child process. A
24 // utility process is a short-lived process that is created to run a specific 25 // utility process is a short-lived process that is created to run a specific
25 // task. This class lives solely on the IO thread. 26 // task. This class lives solely on the IO thread.
26 // If you need a single method call in the process, use StartFooBar(p). 27 // If you need a single method call in the process, use StartFooBar(p).
27 // If you need multiple batches of work to be done in the process, use 28 // If you need multiple batches of work to be done in the process, use
28 // StartBatchMode(), then multiple calls to StartFooBar(p), then finish with 29 // StartBatchMode(), then multiple calls to StartFooBar(p), then finish with
29 // EndBatchMode(). 30 // EndBatchMode().
31 // If you need to call Mojo services, use StartMojoMode() to start the child
32 // process and GetServiceRegistry() to get the service registry to connect to
33 // the child's Mojo services.
30 // 34 //
31 // Note: If your class keeps a ptr to an object of this type, grab a weak ptr to 35 // Note: If your class keeps a ptr to an object of this type, grab a weak ptr to
32 // avoid a use after free since this object is deleted synchronously but the 36 // avoid a use after free since this object is deleted synchronously but the
33 // client notification is asynchronous. See http://crbug.com/108871. 37 // client notification is asynchronous. See http://crbug.com/108871.
34 class UtilityProcessHost : public IPC::Sender, 38 class UtilityProcessHost : public IPC::Sender,
35 public base::SupportsWeakPtr<UtilityProcessHost> { 39 public base::SupportsWeakPtr<UtilityProcessHost> {
36 public: 40 public:
37 // Used to create a utility process. |client| is optional. If supplied it will 41 // Used to create a utility process. |client| is optional. If supplied it will
38 // be notified of incoming messages from the utility process. 42 // be notified of incoming messages from the utility process.
39 // |client_task_runner| is required if |client| is supplied and is the task 43 // |client_task_runner| is required if |client| is supplied and is the task
(...skipping 25 matching lines...) Expand all
65 // Make the process run elevated. 69 // Make the process run elevated.
66 virtual void ElevatePrivileges() = 0; 70 virtual void ElevatePrivileges() = 0;
67 #endif 71 #endif
68 72
69 // Returns information about the utility child process. 73 // Returns information about the utility child process.
70 virtual const ChildProcessData& GetData() = 0; 74 virtual const ChildProcessData& GetData() = 0;
71 75
72 #if defined(OS_POSIX) 76 #if defined(OS_POSIX)
73 virtual void SetEnv(const base::EnvironmentMap& env) = 0; 77 virtual void SetEnv(const base::EnvironmentMap& env) = 0;
74 #endif 78 #endif
79
80 // Starts the utility process in Mojo mode.
81 virtual bool StartMojoMode() = 0;
82
83 // Returns the ServiceRegistry for this process.
Sam McNally 2015/03/09 03:36:15 Is this valid to call if the utility process wasn'
Anand Mistry (off Chromium) 2015/03/10 07:24:24 No. Added comment.
84 virtual ServiceRegistry* GetServiceRegistry() = 0;
75 }; 85 };
76 86
77 }; // namespace content 87 }; // namespace content
78 88
79 #endif // CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_ 89 #endif // CONTENT_PUBLIC_BROWSER_UTILITY_PROCESS_HOST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698