Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 940443003: Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet. (Closed)

Created:
5 years, 10 months ago by fukino
Modified:
5 years, 10 months ago
Reviewers:
yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet. Now that volumes other than Google Drive can be expanded in the directory tree, there is a case that subdirectories are queried befor the displayroot of volume is obtained. In this case, we should skip updating subdirectories. After the displayroot is obtained, updateSubDirectories will be called. BUG=459534 TEST=manually check the steps described in the issue. Committed: https://crrev.com/94b2fd417e4fee909fe42b6e801e0fc3b2098039 Cr-Commit-Position: refs/heads/master@{#316994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M ui/file_manager/file_manager/background/js/volume_manager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/naming_controller.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 2 chunks +6 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
PTAL. Thanks!
5 years, 10 months ago (2015-02-18 11:48:27 UTC) #2
yawano
lgtm. Thank you!
5 years, 10 months ago (2015-02-19 01:33:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940443003/1
5 years, 10 months ago (2015-02-19 05:26:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 05:53:09 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 05:53:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94b2fd417e4fee909fe42b6e801e0fc3b2098039
Cr-Commit-Position: refs/heads/master@{#316994}

Powered by Google App Engine
This is Rietveld 408576698