ui/file_manager/file_manager/foreground/js/naming_controller.js - Issue 940443003: Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/naming_controller.js

Issue 940443003: Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/directory_model.js ('k') | ui/file_manager/file_manager/foreground/js/ui/directory_tree.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/naming_controller.js

diff --git a/ui/file_manager/file_manager/foreground/js/naming_controller.js b/ui/file_manager/file_manager/foreground/js/naming_controller.js

index 8fdda9bee095be3f2e20aa986b4d4f87efc0b503..50a6ff3c70724a431ee78f538ac578d33bbcac35 100644

--- a/ui/file_manager/file_manager/foreground/js/naming_controller.js

+++ b/ui/file_manager/file_manager/foreground/js/naming_controller.js

@@ -103,7 +103,7 @@ NamingController.prototype.validateFileNameForSaving = function(filename) {

if (!isValid)

return Promise.reject('Invalid filename.');

- if (util.isFakeEntry(directory)) {

+ if (directory && util.isFakeEntry(directory)) {

// Can't save a file into a fake directory.

return Promise.reject('Cannot save into fake entry.');

}