ui/file_manager/file_manager/foreground/js/ui/directory_tree.js - Issue 940443003: Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Issue 940443003: Files.app: Skip updating subdirectories of a volume whose display root is not gotten yet. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/js/naming_controller.js ('k') | ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

diff --git a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

index 724c1621077809e6066e0e481a1ddb4c94fbb00d..ca9be48c43b4b3d84c3e424100f9234034a40404 100644

--- a/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

+++ b/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

@@ -223,7 +223,7 @@ DirectoryItem.prototype.handleClick = function(e) {

DirectoryItem.prototype.updateSubDirectories = function(

recursive, opt_successCallback, opt_errorCallback) {

- if (util.isFakeEntry(this.entry)) {

+ if (!this.entry || util.isFakeEntry(this.entry)) {

if (opt_errorCallback)

opt_errorCallback();

return;

@@ -445,6 +445,11 @@ function VolumeItem(modelItem, tree) {

VolumeItem.prototype = {

__proto__: DirectoryItem.prototype,

+ /**

+ * Directory entry for the display root, whose initial value is null.

+ * @type {DirectoryEntry}

+ * @override

+ */

get entry() {

return this.volumeInfo_.displayRoot;