Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 940003002: Reflect debug mode build in flags hash. (Closed)

Created:
5 years, 10 months ago by Yang
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reflect debug mode build in flags hash. R=vogelheim@chromium.org Committed: https://crrev.com/0942a4c48e9c0e4ea450aa92386201e5fa0072b7 Cr-Commit-Position: refs/heads/master@{#26749}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/flags.cc View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 10 months ago (2015-02-19 12:31:20 UTC) #1
vogelheim
lgtm https://codereview.chromium.org/940003002/diff/1/src/flags.cc File src/flags.cc (right): https://codereview.chromium.org/940003002/diff/1/src/flags.cc#newcode558 src/flags.cc:558: #endif // DEBUG Not sure if this is ...
5 years, 10 months ago (2015-02-19 12:49:05 UTC) #2
Yang
https://codereview.chromium.org/940003002/diff/1/src/flags.cc File src/flags.cc (right): https://codereview.chromium.org/940003002/diff/1/src/flags.cc#newcode558 src/flags.cc:558: #endif // DEBUG On 2015/02/19 12:49:05, vogelheim wrote: > ...
5 years, 10 months ago (2015-02-19 12:51:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/940003002/1
5 years, 10 months ago (2015-02-19 12:52:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-19 13:11:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-19 13:11:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0942a4c48e9c0e4ea450aa92386201e5fa0072b7
Cr-Commit-Position: refs/heads/master@{#26749}

Powered by Google App Engine
This is Rietveld 408576698