Reflect debug mode build in flags hash.

src/flags.cc

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <cctype>
 #include <cstdlib>
 #include <sstream>
 
 #include "src/v8.h"
 
@@ skipping 535 matching lines @@
 // static
 void FlagList::EnforceFlagImplications() {
 #define FLAG_MODE_DEFINE_IMPLICATIONS
 #include "src/flag-definitions.h"
 #undef FLAG_MODE_DEFINE_IMPLICATIONS
 }
 
 
 uint32_t FlagList::Hash() {
   std::ostringstream modified_args_as_string;
+#ifdef DEBUG
+  modified_args_as_string << "debug";
+#endif  // DEBUG

[vogelheim, 2015/02/19 12:49:05]

Not sure if this is the best location for this... But I guess it's fine, since
this is only used for the snapshot/code caching checks anyhow.

[Yang, 2015/02/19 12:51:07]

My reasoning is that debug mode is a build time *flag*, so... :)

   for (size_t i = 0; i < num_flags; ++i) {
     Flag* current = &flags[i];
     if (!current->IsDefault()) {
       modified_args_as_string << i;
       modified_args_as_string << *current;
     }
   }
   std::string args(modified_args_as_string.str());
   return static_cast<uint32_t>(
       base::hash_range(args.c_str(), args.c_str() + args.length()));
 }
 } }  // namespace v8::internal