Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: src/flags.cc

Issue 940003002: Reflect debug mode build in flags hash. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/flags.cc
diff --git a/src/flags.cc b/src/flags.cc
index 5e33bdaeec8862ab4249a221f84c60703e9e3401..d498c28240488916d96ce8e7560328682981d31a 100644
--- a/src/flags.cc
+++ b/src/flags.cc
@@ -553,6 +553,9 @@ void FlagList::EnforceFlagImplications() {
uint32_t FlagList::Hash() {
std::ostringstream modified_args_as_string;
+#ifdef DEBUG
+ modified_args_as_string << "debug";
+#endif // DEBUG
vogelheim 2015/02/19 12:49:05 Not sure if this is the best location for this...
Yang 2015/02/19 12:51:07 My reasoning is that debug mode is a build time *f
for (size_t i = 0; i < num_flags; ++i) {
Flag* current = &flags[i];
if (!current->IsDefault()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698