Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 939793003: Change the return value of RenderLayer::hitTestLayer. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change the return value of RenderLayer::hitTestLayer. All the code only cares about whether we hit, not which layer we hit. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/febe2c3fad3f015974828c44fb901a834713ab3b

Patch Set 1 #

Patch Set 2 : remove redundant bool #

Patch Set 3 : fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -41 lines) Patch
M sky/engine/core/rendering/RenderLayer.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 1 7 chunks +18 lines, -32 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-19 03:52:08 UTC) #2
ojan
5 years, 10 months ago (2015-02-19 03:52:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
febe2c3fad3f015974828c44fb901a834713ab3b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698