Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 939273002: Rename rendering/RenderFieldset to layout/LayoutFieldset. (Closed)

Created:
5 years, 10 months ago by dsinclair
Modified:
5 years, 10 months ago
CC:
aboxhall, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, dglazkov+blink, dmazzoni, Dominik Röttsches, dshwang, eae+blinkwatch, jchaffraix+rendering, je_julie(Not used), leviw+renderwatch, nektarios, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename rendering/RenderFieldset to layout/LayoutFieldset. BUG=450612 TBR=jchaffraix@chromium.org, dmazzoni@chromium.org, Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190670

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -542 lines) Patch
M LayoutTests/fast/block/basic/fieldset-stretch-to-legend-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/fast/borders/fieldsetBorderRadius-expected.txt View 1 chunk +22 lines, -22 lines 0 comments Download
M LayoutTests/platform/android/fast/block/basic/fieldset-stretch-to-legend-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/platform/android/fast/forms/fieldset-align-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/android/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/fast/writing-mode/fieldsets-expected.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/platform/android/svg/custom/inline-svg-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/android/virtual/slimmingpaint/fast/block/basic/fieldset-stretch-to-legend-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M LayoutTests/platform/android/virtual/slimmingpaint/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/css/fieldset-display-row-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/007-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/fieldset-align-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/linux/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/fieldset-with-float-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/float-before-fieldset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/writing-mode/fieldsets-expected.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/platform/linux/svg/custom/inline-svg-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/virtual/slimmingpaint/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/css/fieldset-display-row-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/007-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/fieldset-align-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/fieldset-with-float-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/forms/float-before-fieldset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/fast/writing-mode/fieldsets-expected.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/antialiasedtext/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/css/fieldset-display-row-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/virtual/slimmingpaint/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/css/fieldset-display-row-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/007-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/fieldset-align-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/fieldset-with-float-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/float-before-fieldset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/writing-mode/fieldsets-expected.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/platform/win-xp/svg/custom/inline-svg-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/virtual/antialiasedtext/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win-xp/virtual/slimmingpaint/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/css/fieldset-display-row-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/006-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/007-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/fieldset-align-expected.txt View 4 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/fieldset-with-float-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/forms/float-before-fieldset-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/fast/writing-mode/fieldsets-expected.txt View 4 chunks +12 lines, -12 lines 0 comments Download
M LayoutTests/platform/win/svg/custom/inline-svg-in-xhtml-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/antialiasedtext/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/virtual/slimmingpaint/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/virtual/slimmingpaint/fast/block/basic/fieldset-stretch-to-legend-expected.txt View 1 chunk +20 lines, -20 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
A + Source/core/layout/LayoutFieldset.h View 2 chunks +7 lines, -7 lines 0 comments Download
A + Source/core/layout/LayoutFieldset.cpp View 5 chunks +7 lines, -7 lines 0 comments Download
M Source/core/paint/FieldsetPainter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/paint/FieldsetPainter.cpp View 2 chunks +25 lines, -25 lines 0 comments Download
D Source/core/rendering/RenderFieldset.h View 1 chunk +0 lines, -55 lines 0 comments Download
D Source/core/rendering/RenderFieldset.cpp View 1 chunk +0 lines, -151 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939273002/1
5 years, 10 months ago (2015-02-19 20:42:31 UTC) #3
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 10 months ago (2015-02-19 22:22:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/939273002/20001
5 years, 10 months ago (2015-02-23 15:01:32 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 17:31:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190670

Powered by Google App Engine
This is Rietveld 408576698